Truncate the Javascript alert message if the length is too long on Mac port

chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/i18n/rtl.h"
 #include "base/logging.h"
 #import "base/mac/foundation_util.h"
 #include "base/strings/sys_string_conversions.h"
 #import "chrome/browser/chrome_browser_application_mac.h"
 #include "chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.h"
 #include "grit/generated_resources.h"
 #include "grit/ui_strings.h"
 #include "ui/base/l10n/l10n_util_mac.h"
 #include "ui/base/ui_base_types.h"
 
+const int kSlotsPerLine = 50;
+const int kMessageTextMaxSlots = 2000;
+
 // Helper object that receives the notification that the dialog/sheet is
 // going away. Is responsible for cleaning itself up.
 @interface JavaScriptAppModalDialogHelper : NSObject<NSAlertDelegate> {
  @private
   base::scoped_nsobject<NSAlert> alert_;
   NSTextField* textField_;  // WEAK; owned by alert_
 }
 
 - (NSAlert*)alert;
 - (NSTextField*)textField;
@@ skipping 109 matching lines @@
   alert_ = [helper_ alert];
   NSTextField* field = nil;
   if (text_field) {
     field = [helper_ textField];
     [field setStringValue:base::SysUTF16ToNSString(
         dialog_->default_prompt_text())];
   }
   [alert_ setDelegate:helper_];
   NSString* informative_text =
       base::SysUTF16ToNSString(dialog_->message_text());
+
+  // Truncate long JS alerts - crbug.com/331219
+  NSArray* info_array =
+      [informative_text componentsSeparatedByCharactersInSet:
+          [NSCharacterSet newlineCharacterSet]];
+  informative_text = [[NSString alloc] init];

[Avi (use Gerrit), 2014/01/24 01:53:24]

This leaks. You can do

informative_text = @"";

+  int occupied_slots = 0;
+  for (NSString* info_text in info_array) {
+    int new_slots =
+        info_text.length < kSlotsPerLine ? kSlotsPerLine : info_text.length;

[Avi (use Gerrit), 2014/01/24 01:53:24]

std::max?

+    int free_slots = kMessageTextMaxSlots - occupied_slots;

[Avi (use Gerrit), 2014/01/24 01:53:24]

You recompute free_slots each time; easier is to make line 158:

int free_slots = kMessageTextMaxSlots;

drop this line, and then below on line 166 do:

free_slots -= new_slots;

+    if (free_slots >= new_slots) {
+      informative_text = [informative_text stringByAppendingString:info_text];
+      informative_text = [informative_text stringByAppendingString:@"\n"];
+      occupied_slots += new_slots;
+    } else {
+      if ((int)info_text.length > free_slots)

[Avi (use Gerrit), 2014/01/24 01:53:24]

Alleviate the need for a cast if you make free_slots a size_t.

+          info_text = [info_text substringToIndex:free_slots];

[Avi (use Gerrit), 2014/01/24 01:53:24]

Indent 2 for an if().

+      informative_text = [informative_text stringByAppendingString:info_text];
+      informative_text = [informative_text stringByAppendingString:@"\n..."];

[Avi (use Gerrit), 2014/01/24 01:53:24]

What bums me out is that we have gfx::TruncateString to do exactly this kind of
truncation. Can we be clever in counting to re-use it?

+      break;
+    }
+  }
+
   [alert_ setInformativeText:informative_text];
   NSString* message_text =
       base::SysUTF16ToNSString(dialog_->title());
   [alert_ setMessageText:message_text];
   [alert_ addButtonWithTitle:default_button];
   if (!one_button) {
     NSButton* other = [alert_ addButtonWithTitle:other_button];
     [other setKeyEquivalent:@"\e"];
   }
   if (dialog_->display_suppress_checkbox()) {
@@ skipping 139 matching lines @@
 
 ////////////////////////////////////////////////////////////////////////////////
 // NativeAppModalDialog, public:
 
 // static
 NativeAppModalDialog* NativeAppModalDialog::CreateNativeJavaScriptPrompt(
     JavaScriptAppModalDialog* dialog,
     gfx::NativeWindow parent_window) {
   return new JavaScriptAppModalDialogCocoa(dialog);
 }