Truncate the Javascript alert message if the length is too long on Mac port

chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/i18n/rtl.h"
 #include "base/logging.h"
 #import "base/mac/foundation_util.h"
 #include "base/strings/sys_string_conversions.h"
 #import "chrome/browser/chrome_browser_application_mac.h"
 #include "chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.h"
 #include "grit/generated_resources.h"
 #include "grit/ui_strings.h"
 #include "ui/base/l10n/l10n_util_mac.h"
 #include "ui/base/ui_base_types.h"
 
+const int kMessageTextMaxRows = 32;

[jeremy, 2014/01/21 21:24:39]

This is a cross-platform limit right, WDYT about using one constant across
platforms?

+
 // Helper object that receives the notification that the dialog/sheet is
 // going away. Is responsible for cleaning itself up.
 @interface JavaScriptAppModalDialogHelper : NSObject<NSAlertDelegate> {
  @private
   base::scoped_nsobject<NSAlert> alert_;
   NSTextField* textField_;  // WEAK; owned by alert_
 }
 
 - (NSAlert*)alert;
 - (NSTextField*)textField;
@@ skipping 109 matching lines @@
   alert_ = [helper_ alert];
   NSTextField* field = nil;
   if (text_field) {
     field = [helper_ textField];
     [field setStringValue:base::SysUTF16ToNSString(
         dialog_->default_prompt_text())];
   }
   [alert_ setDelegate:helper_];
   NSString* informative_text =
       base::SysUTF16ToNSString(dialog_->message_text());
+
+  NSArray * informative_text_array =

[jeremy, 2014/01/21 21:24:39]

Add a comment with a link to the bug - something like:
// Truncate long JS alerts - crbug.com/331219

+      [informative_text componentsSeparatedByCharactersInSet:
+          [NSCharacterSet newlineCharacterSet]];
+  if ([informative_text_array count] > kMessageTextMaxRows) {
+      informative_text = [[[[informative_text_array subarrayWithRange:
+          NSMakeRange(0, kMessageTextMaxRows)] valueForKey:@"description"]
+          componentsJoinedByString:@"\n"] stringByAppendingString:@"\n..."];

[jeremy, 2014/01/21 21:24:39]

Can you split this up into 3 or 4 statements so this is a little more readable?

+  }
+
   [alert_ setInformativeText:informative_text];
   NSString* message_text =
       base::SysUTF16ToNSString(dialog_->title());
   [alert_ setMessageText:message_text];
   [alert_ addButtonWithTitle:default_button];
   if (!one_button) {
     NSButton* other = [alert_ addButtonWithTitle:other_button];
     [other setKeyEquivalent:@"\e"];
   }
   if (dialog_->display_suppress_checkbox()) {
@@ skipping 139 matching lines @@
 
 ////////////////////////////////////////////////////////////////////////////////
 // NativeAppModalDialog, public:
 
 // static
 NativeAppModalDialog* NativeAppModalDialog::CreateNativeJavaScriptPrompt(
     JavaScriptAppModalDialog* dialog,
     gfx::NativeWindow parent_window) {
   return new JavaScriptAppModalDialogCocoa(dialog);
 }