Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 140323004: Mark private method layoutBlockFlow as inline (Closed)

Created:
6 years, 11 months ago by atreat
Modified:
6 years, 11 months ago
Reviewers:
esprehn, Inactive
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Mark private method layoutBlockFlow as inline Mark private method layoutBlockFlow as inline since it is only used in the implementation file and this appears to be performance critical code. This is an attempt to fix a regression introduced by r165254. This also reduces the binary size on clang by 40 bytes. BUG=33574 R=esprehn@chromium.org, ch.dumez@samsung.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165419

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/rendering/RenderBlockFlow.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 6 (0 generated)
atreat
Please have a look.
6 years, 11 months ago (2014-01-20 18:53:05 UTC) #1
Inactive
lgtm https://codereview.chromium.org/140323004/diff/1/Source/core/rendering/RenderBlockFlow.cpp File Source/core/rendering/RenderBlockFlow.cpp (right): https://codereview.chromium.org/140323004/diff/1/Source/core/rendering/RenderBlockFlow.cpp#newcode254 Source/core/rendering/RenderBlockFlow.cpp:254: inline void RenderBlockFlow::layoutBlockFlow(bool relayoutChildren, LayoutUnit pageLogicalHeight) Yes, looking ...
6 years, 11 months ago (2014-01-20 18:57:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/140323004/1
6 years, 11 months ago (2014-01-20 18:58:02 UTC) #3
Inactive
On 2014/01/20 18:58:02, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 11 months ago (2014-01-20 19:10:47 UTC) #4
atreat
On 2014/01/20 19:10:47, Chris Dumez wrote: > On 2014/01/20 18:58:02, I haz the power (commit-bot) ...
6 years, 11 months ago (2014-01-20 19:14:20 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-20 20:08:54 UTC) #6
Message was sent while issue was closed.
Change committed as 165419

Powered by Google App Engine
This is Rietveld 408576698