Reset margins when destination selected, not when capabilities are ready.

chrome/browser/resources/print_preview/data/print_ticket_store.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('print_preview', function() {
   'use strict';
 
   // TODO(rltoscano): Maybe clear print ticket when destination changes. Or
   // better yet, carry over any print ticket state that is possible. I.e. if
   // destination changes, the new destination might not support duplex anymore,
@@ skipping 372 matching lines @@
       return JSON.stringify(cjt);
     },
 
     /**
      * Adds event listeners for the print ticket store.
      * @private
      */
     addEventListeners_: function() {
       this.tracker_.add(
           this.destinationStore_,
+          print_preview.DestinationStore.EventType.DESTINATION_SELECT,
+          this.onDestinationSelect_.bind(this));
+
+      this.tracker_.add(
+          this.destinationStore_,
           print_preview.DestinationStore.EventType.
               SELECTED_DESTINATION_CAPABILITIES_READY,
           this.onSelectedDestinationCapabilitiesReady_.bind(this));
 
       this.tracker_.add(
           this.destinationStore_,
           print_preview.DestinationStore.EventType.
               CACHED_SELECTED_DESTINATION_INFO_READY,
           this.onSelectedDestinationCapabilitiesReady_.bind(this));
 
       // TODO(rltoscano): Print ticket store shouldn't be re-dispatching these
       // events, the consumers of the print ticket store events should listen
       // for the events from document info instead. Will move this when
       // consumers are all migrated.
       this.tracker_.add(
           this.documentInfo_,
           print_preview.DocumentInfo.EventType.CHANGE,
           this.onDocumentInfoChange_.bind(this));
     },
 
     /**
+     * Called when the destination selected.
+     * @private
+     */
+    onDestinationSelect_: function() {
+      // Reset user selection for certain ticket items.
+      if (this.capabilitiesHolder_.get() != null) {
+        this.customMargins_.updateValue(null);
+        if (this.marginsType_.getValue() ==
+            print_preview.ticket_items.MarginsType.Value.CUSTOM) {
+          this.marginsType_.updateValue(
+              print_preview.ticket_items.MarginsType.Value.DEFAULT);
+        }
+      }
+    },
+
+    /**
      * Called when the capabilities of the selected destination are ready.
      * @private
      */
     onSelectedDestinationCapabilitiesReady_: function() {
       var caps = this.destinationStore_.selectedDestination.capabilities;
       var isFirstUpdate = this.capabilitiesHolder_.get() == null;
       this.capabilitiesHolder_.set(caps);
       if (isFirstUpdate) {
         this.isInitialized_ = true;
         cr.dispatchSimpleEvent(this, PrintTicketStore.EventType.INITIALIZE);
       } else {
-        // Reset user selection for certain ticket items.
-        this.customMargins_.updateValue(null);
-
-        if (this.marginsType_.getValue() ==
-            print_preview.ticket_items.MarginsType.Value.CUSTOM) {
-          this.marginsType_.updateValue(
-              print_preview.ticket_items.MarginsType.Value.DEFAULT);
-        }
         cr.dispatchSimpleEvent(
             this, PrintTicketStore.EventType.CAPABILITIES_CHANGE);
       }
     },
 
     /**
      * Called when document data model has changed. Dispatches a print ticket
      * store event.
      * @private
      */
     onDocumentInfoChange_: function() {
       cr.dispatchSimpleEvent(this, PrintTicketStore.EventType.DOCUMENT_CHANGE);
     },
   };
 
   // Export
   return {
     PrintTicketStore: PrintTicketStore
   };
 });