Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1403223003: [turbofan] Make native context specialization dependent on the typed pipeline. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Make native context specialization dependent on the typed pipeline. Also refactor the JSGlobalSpecialization somewhat to reduce the amount of duplicated code somewhat. R=jarin@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/ffd0a2ae74187af5668c43ea45ef66c2d7cd2444 Cr-Commit-Position: refs/heads/master@{#31286}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -108 lines) Patch
M src/compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-global-specialization.h View 3 chunks +4 lines, -5 lines 0 comments Download
M src/compiler/js-global-specialization.cc View 7 chunks +65 lines, -84 lines 0 comments Download
M src/compiler/js-inlining.cc View 2 chunks +4 lines, -11 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 2 months ago (2015-10-15 09:17:05 UTC) #1
Benedikt Meurer
Hey Jaro, Please take a look. Thanks, Benedikt
5 years, 2 months ago (2015-10-15 09:17:29 UTC) #2
Jarin
lgtm
5 years, 2 months ago (2015-10-15 09:43:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403223003/1
5 years, 2 months ago (2015-10-15 10:24:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-15 10:25:45 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 10:25:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffd0a2ae74187af5668c43ea45ef66c2d7cd2444
Cr-Commit-Position: refs/heads/master@{#31286}

Powered by Google App Engine
This is Rietveld 408576698