Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1403153002: skia: Fix command buffer support on the mac (Closed)

Created:
5 years, 2 months ago by hendrikw
Modified:
5 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

skia: Fix command buffer support on the mac The extension on the mac is .dylib, updated the name. EGL.h isn't available on mac (unless we include skia_angle.h). I've got a somewhat bad hack of defining the types that I need to get this running. GetProcedureAddress was somehow successfully grabbing gl functions from another lib. Removed this call, I copied it from ANGLE impl, but it isn't required. lib load path works differently, fixed in GYP BUG=skia:2992 Committed: https://skia.googlesource.com/skia/+/855dc9395f3b13e1087aae3351a2a368fb89c11e

Patch Set 1 #

Patch Set 2 : load functions from correct lib #

Patch Set 3 : fix merge error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -10 lines) Patch
M gyp/common_conditions.gypi View 1 1 chunk +7 lines, -1 line 0 comments Download
M src/gpu/gl/command_buffer/SkCommandBufferGLContext.cpp View 1 4 chunks +45 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
hendrikw
PTAL, thanks!
5 years, 1 month ago (2015-10-27 16:28:48 UTC) #3
bsalomon
lgtm
5 years, 1 month ago (2015-10-27 16:52:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403153002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403153002/40001
5 years, 1 month ago (2015-10-27 16:53:29 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 17:04:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/855dc9395f3b13e1087aae3351a2a368fb89c11e

Powered by Google App Engine
This is Rietveld 408576698