Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 1403143002: Fix typo in browser_dialogs_mac.cc (Closed)

Created:
5 years, 2 months ago by tapted
Modified:
5 years, 2 months ago
Reviewers:
msw
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix typo in browser_dialogs_mac.cc It #includes a .cc file. It shouldn't. Committed: https://crrev.com/93d2b9a7ef1b4d68656fbce75b172f931442935d Cr-Commit-Position: refs/heads/master@{#354326}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/browser_dialogs_mac.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
tapted
Hi Michael, please take a look (#shameface)
5 years, 2 months ago (2015-10-15 18:44:11 UTC) #2
msw
lgtm
5 years, 2 months ago (2015-10-15 18:54:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1403143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1403143002/1
5 years, 2 months ago (2015-10-15 19:30:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-15 19:35:31 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 19:36:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93d2b9a7ef1b4d68656fbce75b172f931442935d
Cr-Commit-Position: refs/heads/master@{#354326}

Powered by Google App Engine
This is Rietveld 408576698