Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 14031031: Add move semantics to RefPtr

Created:
7 years, 8 months ago by Mikhail
Modified:
7 years, 2 months ago
Reviewers:
Nico, eseidel
CC:
blink-reviews, loislo+blink_chromium.org, jeez, yurys+blink_chromium.org, abarth-chromium, Chris Evans, Nico, jyasskin (not chrome)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add move semantics to RefPtr Add move constructors and move assignment operators to RefPtr when COMPILER_SUPPORTS(CXX_RVALUE_REFERENCES). This obviates unnecessary reffing/ureffing when RefPtr is created or assigned from rvalue references. BUG=

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M Source/wtf/RefPtr.h View 4 chunks +24 lines, -1 line 3 comments Download

Messages

Total messages: 5 (0 generated)
Mikhail
Here is patch adding move constructors and move assignment operators to RefPtr when COMPILER_SUPPORTS(CXX_RVALUE_REFERENCES). This ...
7 years, 8 months ago (2013-04-26 15:17:29 UTC) #1
eseidel
CCing folks more familiar with new c++isms.
7 years, 8 months ago (2013-04-26 18:23:02 UTC) #2
Jeffrey Yasskin
Of course, remember that it's still several months, at least, before we'll be able to ...
7 years, 8 months ago (2013-04-26 19:56:46 UTC) #3
Nico
Even when we turn on C++11 everywhere, we won't allow all features immediately. Do we ...
7 years, 8 months ago (2013-04-26 19:59:17 UTC) #4
Jeffrey Yasskin
7 years, 8 months ago (2013-04-26 20:04:19 UTC) #5
On 2013/04/26 19:59:17, Nico wrote:
> Even when we turn on C++11 everywhere, we won't allow all features
immediately.
> 
> Do we get some measurable gain from this?

It'll let us delete PassRefPtr once we turn on C++11 everywhere. Before then,
it'll only help where people forgot to use PassRefPtr and are building in C++11
mode.

Powered by Google App Engine
This is Rietveld 408576698