src/frames-inl.h - Issue 14031028: Generators save and restore stack handlers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/frames-inl.h

Issue 14031028: Generators save and restore stack handlers (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: Rebase to have the test suite expect boxed return values Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/frames-inl.h

diff --git a/src/frames-inl.h b/src/frames-inl.h

index 7901a5e591c85f8d85431d7dbbecd426e64ab08d..f2b75ba7cc2d2527902a024efedb78dfae2c93c9 100644

--- a/src/frames-inl.h

+++ b/src/frames-inl.h

@@ -216,8 +216,9 @@ Object* JavaScriptFrame::GetParameter(int index) const {

inline Address JavaScriptFrame::GetOperandSlot(int index) const {

Address base = fp() + JavaScriptFrameConstants::kLocal0Offset;

ASSERT(IsAddressAligned(base, kPointerSize));

- ASSERT(type() == JAVA_SCRIPT);

- ASSERT(index < ComputeOperandsCount());

+ ASSERT_EQ(type(), JAVA_SCRIPT);

+ ASSERT_LT(index, ComputeOperandsCount());

+ ASSERT_LE(0, index);

// Operand stack grows down.

return base - index * kPointerSize;

}

« src/frames.cc ('K') | « src/frames.cc ('k') | src/objects.h » ('j') | no next file with comments »