dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart - Issue 14031011: Print the location of duplicated elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart

Issue 14031011: Print the location of duplicated elements. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix type warnings Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« dart/sdk/lib/_internal/compiler/implementation/elements/modelx.dart ('K') | « dart/sdk/lib/_internal/compiler/implementation/library_loader.dart ('k') | dart/sdk/lib/_internal/compiler/implementation/warnings.dart » ('j') | dart/tests/compiler/dart2js/diagnose_ambiguous_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart b/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart

index d409045cbbd6573f9484277c0e0b3745b1a6fc73..b972db8fbb43576ef3ceda3e8493f5d207c4ed80 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart

@@ -1485,6 +1485,7 @@ class TypeResolver {

AmbiguousElement ambiguous = element;

type = reportFailureAndCreateType(

ambiguous.messageKind, ambiguous.messageArguments);

+ ambiguous.diagnose(visitor.mapping.currentElement, compiler);

} else if (!element.impliesType()) {

type = reportFailureAndCreateType(

MessageKind.NOT_A_TYPE, {'node': node.typeName});

@@ -1721,6 +1722,7 @@ class ResolverVisitor extends MappingVisitor<Element> {

AmbiguousElement ambiguous = result;

compiler.reportErrorCode(

node, ambiguous.messageKind, ambiguous.messageArguments);

+ ambiguous.diagnose(enclosingElement, compiler);

return new ErroneousElementX(ambiguous.messageKind,

ambiguous.messageArguments,

name, enclosingElement);