Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14031009: Revert 194579 "Add a virtual keyboard webui at chrome://keyboard/" (Closed)

Created:
7 years, 8 months ago by bryeung
Modified:
7 years, 8 months ago
Reviewers:
bryeung
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 194579 "Add a virtual keyboard webui at chrome://keyboard/" > Add a virtual keyboard webui at chrome://keyboard/ > > This is just the old virtual keyboard that was removed a couple of years > ago, being used as a temporary stand-in. > > BUG=222801 > > Review URL: https://codereview.chromium.org/13652010 TBR=bryeung@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194585

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1584 lines) Patch
M trunk/src/chrome/browser/extensions/component_loader.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/component_loader.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M trunk/src/chrome/browser/extensions/image_loader.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M trunk/src/chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/chrome_repack_resources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/common/extensions/manifest_url_handler.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M trunk/src/chrome/common/url_constants.h View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/chrome/common/url_constants.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/tools/gritsettings/resource_ids View 1 chunk +2 lines, -3 lines 0 comments Download
D trunk/src/ui/keyboard/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/ui/keyboard/keyboard.gyp View 2 chunks +1 line, -36 lines 0 comments Download
D trunk/src/ui/keyboard/keyboard_constants.h View 1 chunk +0 lines, -20 lines 0 comments Download
D trunk/src/ui/keyboard/keyboard_constants.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D trunk/src/ui/keyboard/keyboard_resources.grd View 1 chunk +0 lines, -33 lines 0 comments Download
D trunk/src/ui/keyboard/keyboard_ui_controller.h View 1 chunk +0 lines, -29 lines 0 comments Download
D trunk/src/ui/keyboard/keyboard_ui_controller.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D trunk/src/ui/keyboard/resources/common.js View 1 chunk +0 lines, -716 lines 0 comments Download
D trunk/src/ui/keyboard/resources/images/chevron.svg View 1 chunk +0 lines, -9 lines 0 comments Download
D trunk/src/ui/keyboard/resources/images/del.svg View 1 chunk +0 lines, -17 lines 0 comments Download
D trunk/src/ui/keyboard/resources/images/keyboard.svg View 1 chunk +0 lines, -25 lines 0 comments Download
D trunk/src/ui/keyboard/resources/images/mic.svg View 1 chunk +0 lines, -23 lines 0 comments Download
D trunk/src/ui/keyboard/resources/images/ret.svg View 1 chunk +0 lines, -17 lines 0 comments Download
D trunk/src/ui/keyboard/resources/images/shift.svg View 1 chunk +0 lines, -15 lines 0 comments Download
D trunk/src/ui/keyboard/resources/images/shift-down.svg View 1 chunk +0 lines, -15 lines 0 comments Download
D trunk/src/ui/keyboard/resources/images/tab.svg View 1 chunk +0 lines, -14 lines 0 comments Download
D trunk/src/ui/keyboard/resources/index.html View 1 chunk +0 lines, -10 lines 0 comments Download
D trunk/src/ui/keyboard/resources/layout_us.js View 1 chunk +0 lines, -89 lines 0 comments Download
D trunk/src/ui/keyboard/resources/main.css View 1 chunk +0 lines, -193 lines 0 comments Download
D trunk/src/ui/keyboard/resources/main.js View 1 chunk +0 lines, -192 lines 0 comments Download
D trunk/src/ui/keyboard/resources/manifest.json View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bryeung
7 years, 8 months ago (2013-04-17 13:48:49 UTC) #1
bryeung
Committed patchset #1 manually as r194585.
7 years, 8 months ago (2013-04-17 13:49:00 UTC) #2
bryeung
7 years, 8 months ago (2013-04-17 13:49:42 UTC) #3
Message was sent while issue was closed. 
lgtm

(seems silly reviewing this myself)

Powered by Google App Engine
This is Rietveld 408576698