After http://trac.webkit.org/changeset/20780, when MouseEvent is constructed, it must have a button…

After http://trac.webkit.org/changeset/20780, when MouseEvent is constructed, it must have a button selected. A new member keeps track of whether a button is really pressed. We need to add a check in WebInputEventConversion if a button is really pressed.

BUG=179054
TEST=New test in WebInputEventConversionTest.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148696

[yael.aharon, 2013-04-18 20:56:32]

This patch is associated with https://codereview.chromium.org/14324006/. Please
review them together. Thanks.

[tkent, 2013-04-18 21:43:29]

lgtm

[commit-bot: I haz the power, 2013-04-18 21:44:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yael.aharon@intel.com/14031008/1

[commit-bot: I haz the power, 2013-04-18 21:44:07]

Presubmit check for 14031008-1 failed and returned exit status 1.

INFO:root:Found 2 file(s).
Running presubmit commit checks ...
Running /b/commit-queue/workdir/blink/PRESUBMIT.py
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 33, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1305, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1129, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1046, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 131, in CheckChangeOnCommit
  File "<string>", line 45, in _CommonChecks
  File "/b/depot_tools/presubmit_canned_checks.py", line 983, in
PanProjectChecks
    input_api, output_api, source_file_filter=sources))
  File "/b/depot_tools/presubmit_canned_checks.py", line 306, in
CheckChangeHasNoStrayWhitespace
    input_api, source_file_filter)
  File "/b/depot_tools/presubmit_canned_checks.py", line 260, in
_FindNewViolationsOfRule
    for line_num, line in f.ChangedContents():
  File "/b/depot_tools/presubmit_support.py", line 549, in ChangedContents
    for line in self.GenerateScmDiff().splitlines():
  File "/b/depot_tools/presubmit_support.py", line 619, in GenerateScmDiff
    [self.LocalPath()], self._local_root, False, None)
  File "/b/depot_tools/scm.py", line 913, in GenerateDiff
    full_move, revision))
  File "/b/depot_tools/scm.py", line 837, in _DiffItemInternal
    data = SVN.Capture(command, cwd)
  File "/b/depot_tools/scm.py", line 479, in Capture
    ['svn'] + args, stderr=subprocess2.PIPE, cwd=cwd, **kwargs)
  File "/b/depot_tools/subprocess2.py", line 449, in check_output
    return check_call_out(args, stdout=PIPE, **kwargs)[0]
  File "/b/depot_tools/subprocess2.py", line 412, in check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
subprocess2.CalledProcessError: Command svn diff --internal-diff
Source/WebKit/chromium/src/WebInputEventConversion.cpp returned non-zero exit
status 1 in /b/commit-queue/workdir/blink
svn: invalid option: --internal-diff
Type 'svn help' for usage.

[yael.aharon, 2013-04-18 22:15:39]

Sorry, I am new to this workflow.
Do I need to rebase this patch, or what needs to happen to get it through?
thanks

[commit-bot: I haz the power, 2013-04-18 22:39:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yael.aharon@intel.com/14031008/1

[commit-bot: I haz the power, 2013-04-18 23:08:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yael.aharon@intel.com/14031008/1

[commit-bot: I haz the power, 2013-04-18 23:08:23]

"webkit_tests" failed. Giving up immediately.
Builder is mac_layout_rel, revision is HEAD

[commit-bot: I haz the power, 2013-04-18 23:27:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yael.aharon@intel.com/14031008/1

[commit-bot: I haz the power, 2013-04-18 23:27:07]

"webkit_tests" failed. Giving up immediately.
Builder is mac_layout_rel, revision is HEAD

[commit-bot: I haz the power, 2013-04-18 23:29:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yael.aharon@intel.com/14031008/1

[commit-bot: I haz the power, 2013-04-18 23:46:59]

Change committed as 148696