Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: blimp/common/proto/control.proto

Issue 1403083002: [Blimp] Adds Blimp EngineSession and ClientSession skeleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/common/proto/control.proto
diff --git a/blimp/common/proto/client_control.proto b/blimp/common/proto/control.proto
similarity index 64%
rename from blimp/common/proto/client_control.proto
rename to blimp/common/proto/control.proto
index 6d9f605f556ec51e82bb27de57950509b8e713c2..d6d64c4b9a2b60c969c4871488141e7ce0ccc810 100644
--- a/blimp/common/proto/client_control.proto
+++ b/blimp/common/proto/control.proto
@@ -11,19 +11,22 @@ syntax = "proto2";
option optimize_for = LITE_RUNTIME;
-message NavigateArgs {
+message LoadUrlMessage {
optional string url = 1;
}
-message ClientControlMessage {
+message ControlMessage {
enum Type {
- NAVIGATE = 1;
- STOP = 2;
- RELOAD = 3;
- BACK = 4;
- FORWARD = 5;
+ // Client <=> Server types.
+ CREATE_TAB = 1;
+ CLOSE_TAB = 2;
+ LOAD_URL = 3;
+
+ // Server => Client types.
+ // Client => Server types.
}
optional Type type = 1;
- optional NavigateArgs navigate = 1000;
+ // When the type is LOAD_URL.
Kevin M 2015/10/15 22:01:56 Not necessary; naming convention covers us there.
haibinlu 2015/10/15 22:12:32 Done.
+ optional LoadUrlMessage load_url = 1000;
}

Powered by Google App Engine
This is Rietveld 408576698