Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: mojo/edk/system/dispatcher.h

Issue 1403033003: Last set of fixes to make the src/mojo/edk pass the page cycler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes now that OnError can be called multiple times Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/edk/system/dispatcher.h
diff --git a/mojo/edk/system/dispatcher.h b/mojo/edk/system/dispatcher.h
index 514c32992661a807391e521c306afc088483f229..575471f2d096f0b88dd09cf99de4de8032a5b851 100644
--- a/mojo/edk/system/dispatcher.h
+++ b/mojo/edk/system/dispatcher.h
@@ -270,13 +270,6 @@ class MOJO_SYSTEM_IMPL_EXPORT Dispatcher
// They will only be called on a dispatcher that's attached to and "owned" by
// a |MessageInTransit|. See the non-"impl" versions for more information.
//
- // Note: |StartSerializeImplNoLock()| is actually called with |lock_| NOT
- // held, since the dispatcher should only be accessible to the calling thread.
- // On Debug builds, |EndSerializeAndCloseImplNoLock()| is called with |lock_|
- // held, to satisfy any |lock_.AssertAcquired()| (e.g., in |CloseImplNoLock()|
- // -- and anything it calls); disentangling those assertions is
- // difficult/fragile, and would weaken our general checking of invariants.
- //
// TODO(vtl): Consider making these pure virtual once most things support
// being passed over a message pipe.
virtual void StartSerializeImplNoLock(size_t* max_size,

Powered by Google App Engine
This is Rietveld 408576698