mojo/edk/system/dispatcher.h - Issue 1403033003: Last set of fixes to make the src/mojo/edk pass the page cycler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/edk/system/dispatcher.h

Issue 1403033003: Last set of fixes to make the src/mojo/edk pass the page cycler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixes now that OnError can be called multiple times Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/edk/system/dispatcher.h

diff --git a/mojo/edk/system/dispatcher.h b/mojo/edk/system/dispatcher.h

index 514c32992661a807391e521c306afc088483f229..575471f2d096f0b88dd09cf99de4de8032a5b851 100644

--- a/mojo/edk/system/dispatcher.h

+++ b/mojo/edk/system/dispatcher.h

@@ -270,13 +270,6 @@ class MOJO_SYSTEM_IMPL_EXPORT Dispatcher

// They will only be called on a dispatcher that's attached to and "owned" by

// a |MessageInTransit|. See the non-"impl" versions for more information.

- // Note: |StartSerializeImplNoLock()| is actually called with |lock_| NOT

- // held, since the dispatcher should only be accessible to the calling thread.

- // On Debug builds, |EndSerializeAndCloseImplNoLock()| is called with |lock_|

- // held, to satisfy any |lock_.AssertAcquired()| (e.g., in |CloseImplNoLock()|

- // -- and anything it calls); disentangling those assertions is

- // difficult/fragile, and would weaken our general checking of invariants.

- //

// TODO(vtl): Consider making these pure virtual once most things support

// being passed over a message pipe.

virtual void StartSerializeImplNoLock(size_t* max_size,

« no previous file with comments | « mojo/edk/system/data_pipe_producer_dispatcher.cc ('k') | mojo/edk/system/dispatcher.cc » ('j') | mojo/edk/system/raw_channel_win.cc » ('J')