State-carrying context API.

State-carrying context API.

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/888c4c526f5a942d3168bc58573f364efa82fa97

[pquitslund, 2015-10-13 20:15:01]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com, paulberry@google.com, scheglov@google.com

[pquitslund, 2015-10-13 20:15:01]

Fodder for conversation.  Net-net: I need a way to associate information with
contexts.  (Specifically, plugin configuration details.)

`getAdapter` would work as well probably.  The intent is the same.

Thoughts appreciated!

[Brian Wilkerson, 2015-10-13 20:50:59]

https://codereview.chromium.org/1403033002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/1403033002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/engine.dart:903: * Associate this [state] object
with the given state [key].
"state [key]" --> "[key]"

Perhaps a Dart-like @see: "Use the method [getState] to retrieve the value that
was set." (and another with 'getState').

[pquitslund, 2015-10-14 18:16:23]

Updated as per our conversation.

PTAL!

[scheglov, 2015-10-14 18:20:05]

LGTM

Add couple tests?

https://codereview.chromium.org/1403033002/diff/40001/pkg/analyzer/lib/src/co...
File pkg/analyzer/lib/src/context/context.dart (right):

https://codereview.chromium.org/1403033002/diff/40001/pkg/analyzer/lib/src/co...
pkg/analyzer/lib/src/context/context.dart:121: <ResultDescriptor, Object>{};
new HashMap<>()

https://codereview.chromium.org/1403033002/diff/40001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/1403033002/diff/40001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/engine.dart:594: * state has been associated with
the given [key], returns `null`.
Just curious - why "return" in one case but "returns null"?

https://codereview.chromium.org/1403033002/diff/40001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/engine.dart:596: * See [setConfigurationData]
Add dot?

https://codereview.chromium.org/1403033002/diff/40001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/engine.dart:959: <ResultDescriptor, Object>{};
new HashMap(), otherwise you get LInkedHashMap.

[Brian Wilkerson, 2015-10-14 20:23:21]

Other than what Konstantin already commented on, LGTM.

[pquitslund, 2015-10-14 22:31:46]

Thank you!

https://codereview.chromium.org/1403033002/diff/40001/pkg/analyzer/lib/src/co...
File pkg/analyzer/lib/src/context/context.dart (right):

https://codereview.chromium.org/1403033002/diff/40001/pkg/analyzer/lib/src/co...
pkg/analyzer/lib/src/context/context.dart:121: <ResultDescriptor, Object>{};
On 2015/10/14 18:20:04, scheglov wrote:
> new HashMap<>()

Done.

https://codereview.chromium.org/1403033002/diff/40001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/1403033002/diff/40001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/engine.dart:594: * state has been associated with
the given [key], returns `null`.
On 2015/10/14 18:20:04, scheglov wrote:
> Just curious - why "return" in one case but "returns null"?

Sloppy grammar on my part!

Fixed.

https://codereview.chromium.org/1403033002/diff/40001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/engine.dart:596: * See [setConfigurationData]
On 2015/10/14 18:20:04, scheglov wrote:
> Add dot?

Done.

https://codereview.chromium.org/1403033002/diff/40001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/engine.dart:959: <ResultDescriptor, Object>{};
On 2015/10/14 18:20:04, scheglov wrote:
> new HashMap(), otherwise you get LInkedHashMap.

Cool.  Fixed.  Thanks.

[pquitslund, 2015-10-14 22:33:15]

Committed patchset #4 (id:60001) manually as
888c4c526f5a942d3168bc58573f364efa82fa97 (presubmit successful).