Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 14030003: Remove Chrome Frame's delay shutdown field trial. (Closed)

Created:
7 years, 8 months ago by robertshield
Modified:
7 years, 8 months ago
Reviewers:
jam, grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org, amit
Visibility:
Public.

Description

Remove Chrome Frame's delay shutdown field trial. Delete lots of related code in both Chrome and CF. BUG=229940 TEST=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194798

Patch Set 1 #

Patch Set 2 : Remove lotsa more code, tests. #

Patch Set 3 : Remove additional cruft. #

Total comments: 12

Patch Set 4 : Dear Greg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -152 lines) Patch
M chrome/browser/automation/chrome_frame_automation_provider_win.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/automation/chrome_frame_automation_provider_win.cc View 1 2 3 4 chunks +2 lines, -46 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome_frame/chrome_frame_automation.h View 1 2 6 chunks +2 lines, -19 lines 0 comments Download
M chrome_frame/chrome_frame_automation.cc View 1 2 7 chunks +2 lines, -51 lines 0 comments Download
M chrome_frame/chrome_frame_plugin.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome_frame/chrome_launcher.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/chrome_tab.cc View 1 2 4 chunks +0 lines, -11 lines 0 comments Download
M chrome_frame/metrics_service.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/test/automation_client_mock.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M chrome_frame/test/chrome_frame_automation_mock.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/proxy_factory_mock.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/run_all_unittests.cc View 1 2 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
robertshield
Delete, delete, delete. PTAL.
7 years, 8 months ago (2013-04-10 23:51:00 UTC) #1
robertshield
On 2013/04/10 23:51:00, robertshield wrote: > Delete, delete, delete. PTAL. Greg, more stuff removed, ptal.
7 years, 8 months ago (2013-04-11 15:35:09 UTC) #2
grt (UTC plus 2)
please note in the CL description that this reverts all of r124942 and most of ...
7 years, 8 months ago (2013-04-11 18:15:57 UTC) #3
robertshield
https://codereview.chromium.org/14030003/diff/11001/chrome/browser/automation/chrome_frame_automation_provider_win.cc File chrome/browser/automation/chrome_frame_automation_provider_win.cc (right): https://codereview.chromium.org/14030003/diff/11001/chrome/browser/automation/chrome_frame_automation_provider_win.cc#newcode7 chrome/browser/automation/chrome_frame_automation_provider_win.cc:7: #include <algorithm> On 2013/04/11 18:15:57, grt wrote: > remove ...
7 years, 8 months ago (2013-04-12 19:49:07 UTC) #4
grt (UTC plus 2)
re-upload?
7 years, 8 months ago (2013-04-12 22:32:18 UTC) #5
robertshield
On 2013/04/12 22:32:18, grt wrote: > re-upload? Apologies, re-uploaded.
7 years, 8 months ago (2013-04-14 18:13:23 UTC) #6
grt (UTC plus 2)
lgtm
7 years, 8 months ago (2013-04-15 12:58:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/14030003/21001
7 years, 8 months ago (2013-04-17 23:25:10 UTC) #8
commit-bot: I haz the power
Presubmit check for 14030003-21001 failed and returned exit status 1. INFO:root:Found 14 file(s). Running presubmit ...
7 years, 8 months ago (2013-04-17 23:25:15 UTC) #9
robertshield
+jam for OWNERS
7 years, 8 months ago (2013-04-18 00:09:23 UTC) #10
robertshield
+jam for OWNERS
7 years, 8 months ago (2013-04-18 00:10:01 UTC) #11
jam
lgtm
7 years, 8 months ago (2013-04-18 01:05:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/14030003/21001
7 years, 8 months ago (2013-04-18 03:25:59 UTC) #13
commit-bot: I haz the power
7 years, 8 months ago (2013-04-18 06:03:00 UTC) #14
Message was sent while issue was closed.
Change committed as 194798

Powered by Google App Engine
This is Rietveld 408576698