Move some code from Runtime_GetPrototype into a new Object::GetPrototype.

Move some code from Runtime_GetPrototype into a new Object::GetPrototype.

Also clean up the access check, which was doing too much.

This is in preparation of implementing Reflect.getPrototypeOf.

BUG=

Committed: https://crrev.com/33f1075933b30edf4d659d875d808efcdce2f4bf
Cr-Commit-Position: refs/heads/master@{#31434}

[neis, 2015-10-13 14:55:21]

neis@chromium.org changed reviewers:
+ verwaest@chromium.org

[neis, 2015-10-13 14:55:54]

https://codereview.chromium.org/1402973002/diff/1/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (right):

https://codereview.chromium.org/1402973002/diff/1/src/runtime/runtime-debug.c...
src/runtime/runtime-debug.cc:1455: return
*Object::GetPrototypeWithAccess(isolate, obj);
Is it correct to not do an access check here?  If not (i.e. this should be a
call to GetPrototype), then is it worth having GetPrototypeWithAccess at all? 
The only other place where it's used is in Runtime_SetPrototype, in order to
avoid two redundant checks.

[Toon Verwaest, 2015-10-14 10:56:18]

https://codereview.chromium.org/1402973002/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/1402973002/diff/1/src/objects-inl.h#newcode1197
src/objects-inl.h:1197: Handle<Object> obj) {
If you want to have such a function, make sure it DCHECKs that you do have
access.

https://codereview.chromium.org/1402973002/diff/1/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (right):

https://codereview.chromium.org/1402973002/diff/1/src/runtime/runtime-debug.c...
src/runtime/runtime-debug.cc:1455: return
*Object::GetPrototypeWithAccess(isolate, obj);
On 2015/10/13 14:55:54, neis wrote:
> Is it correct to not do an access check here?  If not (i.e. this should be a
> call to GetPrototype), then is it worth having GetPrototypeWithAccess at all? 
> The only other place where it's used is in Runtime_SetPrototype, in order to
> avoid two redundant checks.

Given that the other 2 cases deal with Object.observe, it might be worthwhile to
just drop that function.

[neis, 2015-10-14 13:39:37]

On 2015/10/14 10:56:18, Toon Verwaest wrote:
> https://codereview.chromium.org/1402973002/diff/1/src/objects-inl.h
> File src/objects-inl.h (right):
> 
>
https://codereview.chromium.org/1402973002/diff/1/src/objects-inl.h#newcode1197
> src/objects-inl.h:1197: Handle<Object> obj) {
> If you want to have such a function, make sure it DCHECKs that you do have
> access.
> 
> https://codereview.chromium.org/1402973002/diff/1/src/runtime/runtime-debug.cc
> File src/runtime/runtime-debug.cc (right):
> 
>
https://codereview.chromium.org/1402973002/diff/1/src/runtime/runtime-debug.c...
> src/runtime/runtime-debug.cc:1455: return
> *Object::GetPrototypeWithAccess(isolate, obj);
> On 2015/10/13 14:55:54, neis wrote:
> > Is it correct to not do an access check here?  If not (i.e. this should be a
> > call to GetPrototype), then is it worth having GetPrototypeWithAccess at
all? 
> > The only other place where it's used is in Runtime_SetPrototype, in order to
> > avoid two redundant checks.
> 
> Given that the other 2 cases deal with Object.observe, it might be worthwhile
to
> just drop that function.

Ok, I did that.

[Toon Verwaest, 2015-10-20 15:12:09]

lgtm

[neis, 2015-10-21 09:45:18]

Description was changed from

==========
Add Object::GetPrototype and use it in %_GetPrototype.

Also clean up the access check, which was doing too much.

This is in preparation of implementing Reflect.getPrototypeOf.

BUG=
==========

to

==========
Move some code from %_GetPrototype into a new Object::GetPrototype.

Also clean up the access check, which was doing too much.

This is in preparation of implementing Reflect.getPrototypeOf.

BUG=
==========

[neis, 2015-10-21 09:47:10]

Description was changed from

==========
Move some code from %_GetPrototype into a new Object::GetPrototype.

Also clean up the access check, which was doing too much.

This is in preparation of implementing Reflect.getPrototypeOf.

BUG=
==========

to

==========
Move some code from Runtime_GetPrototype into a new Object::GetPrototype.

Also clean up the access check, which was doing too much.

This is in preparation of implementing Reflect.getPrototypeOf.

BUG=
==========

[neis, 2015-10-21 10:42:57]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-21 10:43:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1402973002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1402973002/40001

[commit-bot: I haz the power, 2015-10-21 11:14:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-21 11:14:08]

Dry run: This issue passed the CQ dry run.

[neis, 2015-10-21 11:15:46]

The CQ bit was checked by neis@chromium.org

[neis, 2015-10-21 11:15:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1402973002/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2015-10-21 11:15:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1402973002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1402973002/40001

[commit-bot: I haz the power, 2015-10-21 11:17:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-21 11:17:35]

Patchset 3 (id:??) landed as
https://crrev.com/33f1075933b30edf4d659d875d808efcdce2f4bf
Cr-Commit-Position: refs/heads/master@{#31434}