Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1402963002: Move width/height related properties into CSSPropertyParser (Closed)

Created:
5 years, 2 months ago by rwlbuis
Modified:
5 years, 2 months ago
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move width/height related properties into CSSPropertyParser Move width/height related properties handling from LegacyCSSPropertyParser into CSSPropertyParser. BUG=499780 Committed: https://crrev.com/e830a4ca6ed34cf5ca6c83540dac4a8766f48e17 Cr-Commit-Position: refs/heads/master@{#353929}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -58 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 2 chunks +63 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 3 chunks +12 lines, -56 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rwlbuis
PTAL. Sorry for the review flood :)
5 years, 2 months ago (2015-10-13 20:19:46 UTC) #2
Timothy Loh
On 2015/10/13 20:19:46, rwlbuis wrote: > PTAL. Sorry for the review flood :) lgtm
5 years, 2 months ago (2015-10-13 23:32:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402963002/1
5 years, 2 months ago (2015-10-13 23:45:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-14 00:50:05 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 00:52:40 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e830a4ca6ed34cf5ca6c83540dac4a8766f48e17
Cr-Commit-Position: refs/heads/master@{#353929}

Powered by Google App Engine
This is Rietveld 408576698