test/unittests/interpreter/bytecode-array-builder-unittest.cc - Issue 1402943002: [Interpreter] Support for operator new.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/interpreter/bytecode-array-builder-unittest.cc

Issue 1402943002: [Interpreter] Support for operator new. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Incorporate review comments on patch sets 2 and 3. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/unittests/interpreter/bytecode-array-builder-unittest.cc

diff --git a/test/unittests/interpreter/bytecode-array-builder-unittest.cc b/test/unittests/interpreter/bytecode-array-builder-unittest.cc

index 870c26d64a448f4b140b83e5deb2fbc9431f2ad7..acb0ed2d07b386acb81c87a6cf740dbfa77e3ed0 100644

--- a/test/unittests/interpreter/bytecode-array-builder-unittest.cc

+++ b/test/unittests/interpreter/bytecode-array-builder-unittest.cc

@@ -84,6 +84,9 @@ TEST_F(BytecodeArrayBuilderTest, AllBytecodesGenerated) {

// Emit unary operator invocations.

builder.LogicalNot().TypeOf();

+ // Emit new.

+ builder.New(reg, reg, 0);

// Emit test operator invocations.

builder.CompareOperation(Token::Value::EQ, reg, Strength::WEAK)

.CompareOperation(Token::Value::NE, reg, Strength::WEAK)