test/cctest/interpreter/test-bytecode-generator.cc - Issue 1402943002: [Interpreter] Support for operator new.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/interpreter/test-bytecode-generator.cc

Issue 1402943002: [Interpreter] Support for operator new. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Incorporate review comments on patch sets 2 and 3. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/interpreter/test-bytecode-generator.cc

diff --git a/test/cctest/interpreter/test-bytecode-generator.cc b/test/cctest/interpreter/test-bytecode-generator.cc

index e054f970991e3053e48d31c0272749736493a3c8..e0c616fe115272ec12e5fc029697b2a89102ee61 100644

--- a/test/cctest/interpreter/test-bytecode-generator.cc

+++ b/test/cctest/interpreter/test-bytecode-generator.cc

@@ -911,20 +911,20 @@ TEST(PropertyCall) {

30,

{

- B(Ldar), R(helper.kLastParamIndex - 1), //

- B(Star), R(1), //

- B(LdaConstant), U8(0), //

- B(LoadICSloppy), R(1), U8(vector->GetIndex(slot2)), //

- B(Star), R(0), //

- B(Ldar), R(helper.kLastParamIndex), //

- B(Star), R(2), //

- B(Ldar), R(helper.kLastParamIndex), //

- B(Add), R(2), //

- B(Star), R(2), //

- B(Ldar), R(helper.kLastParamIndex), //

- B(Star), R(3), //

- B(Call), R(0), R(1), U8(2), //

- B(Return) //

+ B(Ldar), R(helper.kLastParamIndex - 1), //

+ B(Star), R(1), //

+ B(LdaConstant), U8(0), //

+ B(LoadICSloppy), R(1), U8(5), //

rmcilroy 2015/10/14 10:18:35 please use vector->GetIndex(...) here

oth 2015/10/14 16:02:19 Done.

+ B(Star), R(0), //

+ B(Ldar), R(helper.kLastParamIndex), //

+ B(Star), R(3), //

+ B(Ldar), R(helper.kLastParamIndex), //

+ B(Add), R(3), //

+ B(Star), R(2), //

+ B(Ldar), R(helper.kLastParamIndex), //

+ B(Star), R(3), //

+ B(Call), R(0), R(1), U8(2), //

+ B(Return), //

{"func"}}};

« src/x64/builtins-x64.cc ('K') | « src/x64/interface-descriptors-x64.cc ('k') | test/cctest/interpreter/test-interpreter.cc » ('j') | test/cctest/interpreter/test-interpreter.cc » ('J')