[Interpreter] Support for operator new.

src/interpreter/bytecode-generator.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/bytecode-generator.h"
 
 #include <stack>
 
 #include "src/compiler.h"
 #include "src/interpreter/control-flow-builders.h"
@@ skipping 636 matching lines @@
 
 void BytecodeGenerator::VisitProperty(Property* expr) {
   TemporaryRegisterScope temporary_register_scope(&builder_);
   Register obj = temporary_register_scope.NewRegister();
   Visit(expr->obj());
   builder()->StoreAccumulatorInRegister(obj);
   VisitPropertyLoad(obj, expr);
 }
 
 
+Register BytecodeGenerator::VisitArguments(
+    ZoneList<Expression*>* args, TemporaryRegisterScope* register_scope) {
+  // Visit arguments and place in a contiguous block of temporary registers.
+  // Return the first temporary register corresponding to the first argument.
+  DCHECK_GT(args->length(), 0);
+  Register first_arg = register_scope->NewRegister();
+  Visit(args->at(0));
+  builder()->StoreAccumulatorInRegister(first_arg);
+  for (int i = 1; i < static_cast<int>(args->length()); i++) {
+    Register ith_arg = register_scope->NewRegister();
+    Visit(args->at(i));
+    builder()->StoreAccumulatorInRegister(ith_arg);
+    DCHECK(ith_arg.index() - i == first_arg.index());
+  }
+
+  return first_arg;
+}
+
+
 void BytecodeGenerator::VisitCall(Call* expr) {
   Expression* callee_expr = expr->expression();
   Call::CallType call_type = expr->GetCallType(isolate());
 
   // Prepare the callee and the receiver to the function call. This depends on
   // the semantics of the underlying call type.
   TemporaryRegisterScope temporary_register_scope(&builder_);
   Register callee = temporary_register_scope.NewRegister();
   Register receiver = temporary_register_scope.NewRegister();
 
@@ skipping 27 matching lines @@
     }
     case Call::LOOKUP_SLOT_CALL:
     case Call::SUPER_CALL:
     case Call::POSSIBLY_EVAL_CALL:
       UNIMPLEMENTED();
   }
 
   // Evaluate all arguments to the function call and store in sequential
   // registers.
   ZoneList<Expression*>* args = expr->arguments();
-  for (int i = 0; i < args->length(); ++i) {
-    Visit(args->at(i));
-    Register arg = temporary_register_scope.NewRegister();
-    DCHECK(arg.index() - i == receiver.index() + 1);
-    builder()->StoreAccumulatorInRegister(arg);
+  if (args->length() > 0) {
+    Register first_arg = VisitArguments(args, &temporary_register_scope);
+    CHECK_EQ(first_arg.index(), receiver.index() + 1);
   }
 
   // TODO(rmcilroy): Deal with possible direct eval here?
   // TODO(rmcilroy): Use CallIC to allow call type feedback.
   builder()->Call(callee, receiver, args->length());
 }
 
 
-void BytecodeGenerator::VisitCallNew(CallNew* expr) { UNIMPLEMENTED(); }
+void BytecodeGenerator::VisitCallNew(CallNew* expr) {
+  TemporaryRegisterScope temporary_register_scope(builder());
+  Register constructor = temporary_register_scope.NewRegister();
+  Visit(expr->expression());
+  builder()->StoreAccumulatorInRegister(constructor);
+  ZoneList<Expression*>* args = expr->arguments();
+  if (args->length() > 0) {
+    Register first_arg = VisitArguments(args, &temporary_register_scope);
+    builder()->New(constructor, first_arg, args->length());
+  } else {
+    builder()->New(constructor, constructor, 0);

[rmcilroy, 2015/10/14 10:18:34]

nit - I think it deserves a comment that you are passing the constructor
register as first_arg so that there is a valid register, but it won't be used
since arg_count == 0

[oth, 2015/10/14 16:02:19]

Done.

+  }
+}
 
 
 void BytecodeGenerator::VisitCallRuntime(CallRuntime* expr) {
   if (expr->is_jsruntime()) {
     UNIMPLEMENTED();
   }
 
   // Evaluate all arguments to the runtime call.
-  ZoneList<Expression*>* args = expr->arguments();
   TemporaryRegisterScope temporary_register_scope(&builder_);
-  // Ensure we always have a valid first_arg register even if there are no
-  // arguments to pass.
-  Register first_arg = temporary_register_scope.NewRegister();
-  for (int i = 0; i < args->length(); ++i) {
-    Register arg =
-        (i == 0) ? first_arg : temporary_register_scope.NewRegister();
-    Visit(args->at(i));
-    DCHECK_EQ(arg.index() - i, first_arg.index());
-    builder()->StoreAccumulatorInRegister(arg);
-  }
 
   // TODO(rmcilroy): support multiple return values.
   DCHECK_LE(expr->function()->result_size, 1);
   Runtime::FunctionId function_id = expr->function()->function_id;
+  ZoneList<Expression*>* args = expr->arguments();
+  Register first_arg;
+  if (args->length() > 0) {
+    first_arg = VisitArguments(args, &temporary_register_scope);
+  } else {
+    first_arg = temporary_register_scope.NewRegister();

[rmcilroy, 2015/10/14 10:18:34]

ditto

[oth, 2015/10/14 16:02:19]

Done.

+  }
   builder()->CallRuntime(function_id, first_arg, args->length());
 }
 
 
 void BytecodeGenerator::VisitVoid(UnaryOperation* expr) {
   Visit(expr->expression());
   builder()->LoadUndefined();
 }
 
 
@@ skipping 115 matching lines @@
 int BytecodeGenerator::feedback_index(FeedbackVectorSlot slot) const {
   return info()->feedback_vector()->GetIndex(slot);
 }
 
 
 Register BytecodeGenerator::current_context() const { return current_context_; }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8