Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1402933002: Revert "Post loading tasks on the appropriate WebFrameScheduler's queue." (Closed)

Created:
5 years, 2 months ago by Marc Treib
Modified:
5 years, 2 months ago
CC:
chromium-reviews, blink-reviews-platform-graphics_chromium.org, dshwang, eae+blinkwatch, kinuko+watch, rwlbuis, Yoav Weiss, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-html_chromium.org, jam, Justin Novosad, danakj, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, darin-cc_chromium.org, gavinp+loader_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-api_chromium.org, mlamouri+watch-content_chromium.org, sof, jbroman, feature-media-reviews_chromium.org, krit, Nate Chapin, tyoshino+watch_chromium.org, f(malita), mkwst+moarreviews-renderer_chromium.org, Stephen Chennney, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Post loading tasks on the appropriate WebFrameScheduler's queue." and "Fix a UAF in the BackgroundHtmlParser's constructor" This reverts commit https://crrev.com/f3080498facd16066076e7d459ba7cfda11e582c and https://crrev.com/76d7303845116b1c08bd327c46c99e264b626ada. (CLs: https://codereview.chromium.org/1366883002 and https://codereview.chromium.org/1391013004.) Reason: Seems to have broken lots of browser_tests on WinXP. TBR=jochen@chromium.org BUG=510398, 538660, 541177 Committed: https://crrev.com/57587e3c7053dc33118ba5a2603879fc6010f6de Cr-Commit-Position: refs/heads/master@{#353983}

Patch Set 1 #

Patch Set 2 : fix bad merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -344 lines) Patch
M components/html_viewer/web_url_loader_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/html_viewer/web_url_loader_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M components/scheduler/child/web_task_runner_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/scheduler/child/web_task_runner_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/child/blink_platform_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/child/blink_platform_impl.cc View 3 chunks +11 lines, -3 lines 0 comments Download
M content/child/request_info.h View 2 chunks +0 lines, -8 lines 0 comments Download
M content/child/request_info.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/child/resource_dispatcher.h View 3 chunks +0 lines, -5 lines 0 comments Download
M content/child/resource_dispatcher.cc View 4 chunks +0 lines, -16 lines 0 comments Download
M content/child/resource_scheduling_filter.h View 2 chunks +2 lines, -23 lines 0 comments Download
M content/child/resource_scheduling_filter.cc View 2 chunks +3 lines, -56 lines 0 comments Download
M content/child/web_url_loader_impl.h View 2 chunks +3 lines, -5 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 13 chunks +10 lines, -45 lines 0 comments Download
M content/child/web_url_loader_impl_unittest.cc View 2 chunks +1 line, -5 lines 0 comments Download
M content/renderer/render_thread_impl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 4 chunks +0 lines, -16 lines 0 comments Download
M content/test/mock_weburlloader.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/weburl_loader_mock.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/weburl_loader_mock.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M media/blink/mock_weburlloader.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.h View 5 chunks +5 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp View 11 chunks +9 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp View 12 chunks +10 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/FetchContext.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceLoader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.h View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 4 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.h View 3 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp View 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/TimerTest.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/web/AssociatedURLLoader.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/AssociatedURLLoader.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/platform/WebTaskRunner.h View 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/WebKit/public/platform/WebURLLoader.h View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Marc Treib
5 years, 2 months ago (2015-10-13 10:18:27 UTC) #2
alex clarke (OOO till 29th)
lgtm
5 years, 2 months ago (2015-10-13 10:21:30 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402933002/1
5 years, 2 months ago (2015-10-13 10:23:10 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/126793) mac_chromium_compile_dbg_ng on ...
5 years, 2 months ago (2015-10-13 10:39:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402933002/20001
5 years, 2 months ago (2015-10-13 11:00:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402933002/20001
5 years, 2 months ago (2015-10-14 08:26:46 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-14 08:34:30 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/57587e3c7053dc33118ba5a2603879fc6010f6de Cr-Commit-Position: refs/heads/master@{#353983}
5 years, 2 months ago (2015-10-14 08:35:22 UTC) #16
Marc Treib
5 years, 2 months ago (2015-10-14 12:39:12 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1402103002/ by treib@chromium.org.

The reason for reverting is: The failures happened again after reverting the
original CL, so relanding that..

Powered by Google App Engine
This is Rietveld 408576698