Avoid creating invalid TypeMask.nonNullExact

Avoid creating invalid TypeMask.nonNullExact

BUG=
R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/c1214e8f99ea63f94a45fc3e772c94a4e7a0f12c

[Johnni Winther, 2015-10-13 10:14:54]

johnniwinther@google.com changed reviewers:
+ floitsch@google.com

[Johnni Winther, 2015-10-13 10:14:55]

https://codereview.chromium.org/1402913003/diff/20001/pkg/compiler/lib/src/el...
File pkg/compiler/lib/src/elements/common.dart (right):

https://codereview.chromium.org/1402913003/diff/20001/pkg/compiler/lib/src/el...
pkg/compiler/lib/src/elements/common.dart:410:
allSupertypesAndSelf.asInstanceOf(intrface) != null;
Optimization

https://codereview.chromium.org/1402913003/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/codegen.dart (right):

https://codereview.chromium.org/1402913003/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/codegen.dart:1759: new
TypeMask.nonNullExact(node.caller.superclass, compiler.world);
superMethod is mixed in [superClass] might not be live. We use the super of the
access instead.

https://codereview.chromium.org/1402913003/diff/20001/pkg/compiler/lib/src/ty...
File pkg/compiler/lib/src/types/type_mask.dart (right):

https://codereview.chromium.org/1402913003/diff/20001/pkg/compiler/lib/src/ty...
pkg/compiler/lib/src/types/type_mask.dart:125: "uninstantiated class
$base.\n${classWorld.dump(base)}"));
Improved dump on failure.

[floitsch, 2015-10-13 12:15:42]

LGTM.

https://codereview.chromium.org/1402913003/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/codegen.dart (right):

https://codereview.chromium.org/1402913003/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/codegen.dart:1759: new
TypeMask.nonNullExact(node.caller.superclass, compiler.world);
On 2015/10/13 10:14:55, Johnni Winther wrote:
> superMethod is mixed in [superClass] might not be live. We use the super of
the
> access instead.

add comment.

https://codereview.chromium.org/1402913003/diff/20001/pkg/compiler/lib/src/un...
File pkg/compiler/lib/src/universe/class_set.dart (right):

https://codereview.chromium.org/1402913003/diff/20001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/class_set.dart:131: if (withRespectTo != null) {
if (withRespectTo != null && !child.subclasses().any(isRelatedTo)) {
  continue;
}

[floitsch, 2015-10-13 12:15:57]

Please add a small test.

[Johnni Winther, 2015-10-13 13:06:37]

https://codereview.chromium.org/1402913003/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/codegen.dart (right):

https://codereview.chromium.org/1402913003/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/codegen.dart:1759: new
TypeMask.nonNullExact(node.caller.superclass, compiler.world);
On 2015/10/13 12:15:42, floitsch wrote:
> On 2015/10/13 10:14:55, Johnni Winther wrote:
> > superMethod is mixed in [superClass] might not be live. We use the super of
> the
> > access instead.
> 
> add comment.

Done.

https://codereview.chromium.org/1402913003/diff/20001/pkg/compiler/lib/src/un...
File pkg/compiler/lib/src/universe/class_set.dart (right):

https://codereview.chromium.org/1402913003/diff/20001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/class_set.dart:131: if (withRespectTo != null) {
On 2015/10/13 12:15:42, floitsch wrote:
> if (withRespectTo != null && !child.subclasses().any(isRelatedTo)) {
>   continue;
> }

Done.

[Johnni Winther, 2015-10-13 13:12:51]

Committed patchset #3 (id:40001) manually as
c1214e8f99ea63f94a45fc3e772c94a4e7a0f12c (presubmit successful).