Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: src/debug/debug.h

Issue 1402913002: Debugger: fix stepping when break points are deactivated. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix test for stress test Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/debug/debug.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_DEBUG_DEBUG_H_ 5 #ifndef V8_DEBUG_DEBUG_H_
6 #define V8_DEBUG_DEBUG_H_ 6 #define V8_DEBUG_DEBUG_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/arguments.h" 9 #include "src/arguments.h"
10 #include "src/assembler.h" 10 #include "src/assembler.h"
(...skipping 464 matching lines...) Expand 10 before | Expand all | Expand 10 after
475 void set_live_edit_enabled(bool v) { live_edit_enabled_ = v; } 475 void set_live_edit_enabled(bool v) { live_edit_enabled_ = v; }
476 bool live_edit_enabled() const { 476 bool live_edit_enabled() const {
477 return FLAG_enable_liveedit && live_edit_enabled_; 477 return FLAG_enable_liveedit && live_edit_enabled_;
478 } 478 }
479 479
480 inline bool is_active() const { return is_active_; } 480 inline bool is_active() const { return is_active_; }
481 inline bool is_loaded() const { return !debug_context_.is_null(); } 481 inline bool is_loaded() const { return !debug_context_.is_null(); }
482 inline bool in_debug_scope() const { 482 inline bool in_debug_scope() const {
483 return !!base::NoBarrier_Load(&thread_local_.current_debug_scope_); 483 return !!base::NoBarrier_Load(&thread_local_.current_debug_scope_);
484 } 484 }
485 void set_disable_break(bool v) { break_disabled_ = v; } 485 void set_break_points_active(bool v) { break_points_active_ = v; }
486 486
487 StackFrame::Id break_frame_id() { return thread_local_.break_frame_id_; } 487 StackFrame::Id break_frame_id() { return thread_local_.break_frame_id_; }
488 int break_id() { return thread_local_.break_id_; } 488 int break_id() { return thread_local_.break_id_; }
489 489
490 // Support for embedding into generated code. 490 // Support for embedding into generated code.
491 Address is_active_address() { 491 Address is_active_address() {
492 return reinterpret_cast<Address>(&is_active_); 492 return reinterpret_cast<Address>(&is_active_);
493 } 493 }
494 494
495 Address after_break_target_address() { 495 Address after_break_target_address() {
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
586 v8::Debug::MessageHandler message_handler_; 586 v8::Debug::MessageHandler message_handler_;
587 587
588 static const int kQueueInitialSize = 4; 588 static const int kQueueInitialSize = 4;
589 base::Semaphore command_received_; // Signaled for each command received. 589 base::Semaphore command_received_; // Signaled for each command received.
590 LockingCommandMessageQueue command_queue_; 590 LockingCommandMessageQueue command_queue_;
591 591
592 bool is_active_; 592 bool is_active_;
593 bool is_suppressed_; 593 bool is_suppressed_;
594 bool live_edit_enabled_; 594 bool live_edit_enabled_;
595 bool break_disabled_; 595 bool break_disabled_;
596 bool break_points_active_;
596 bool in_debug_event_listener_; 597 bool in_debug_event_listener_;
597 bool break_on_exception_; 598 bool break_on_exception_;
598 bool break_on_uncaught_exception_; 599 bool break_on_uncaught_exception_;
599 600
600 DebugInfoListNode* debug_info_list_; // List of active debug info objects. 601 DebugInfoListNode* debug_info_list_; // List of active debug info objects.
601 602
602 // Storage location for jump when exiting debug break calls. 603 // Storage location for jump when exiting debug break calls.
603 // Note that this address is not GC safe. It should be computed immediately 604 // Note that this address is not GC safe. It should be computed immediately
604 // before returning to the DebugBreakCallHelper. 605 // before returning to the DebugBreakCallHelper.
605 Address after_break_target_; 606 Address after_break_target_;
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
759 760
760 static void PatchDebugBreakSlot(Address pc, Handle<Code> code); 761 static void PatchDebugBreakSlot(Address pc, Handle<Code> code);
761 static void ClearDebugBreakSlot(Address pc); 762 static void ClearDebugBreakSlot(Address pc);
762 }; 763 };
763 764
764 765
765 } // namespace internal 766 } // namespace internal
766 } // namespace v8 767 } // namespace v8
767 768
768 #endif // V8_DEBUG_DEBUG_H_ 769 #endif // V8_DEBUG_DEBUG_H_
OLDNEW
« no previous file with comments | « no previous file | src/debug/debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698