Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: runtime/lib/mirrors.cc

Issue 14029016: Remove legacy debugger API function (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/include/dart_debugger_api.h ('k') | runtime/vm/debugger_api_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors.cc
===================================================================
--- runtime/lib/mirrors.cc (revision 21241)
+++ runtime/lib/mirrors.cc (working copy)
@@ -833,17 +833,23 @@
// TODO(turnidge): This should be an immutable map.
Dart_Handle map = MapNew();
- Dart_Handle lib_urls = Dart_GetLibraryURLs();
- if (Dart_IsError(lib_urls)) {
- return lib_urls;
+ Dart_Handle lib_ids = Dart_GetLibraryIds();
+ if (Dart_IsError(lib_ids)) {
+ return lib_ids;
}
intptr_t len;
- Dart_Handle result = Dart_ListLength(lib_urls, &len);
+ Dart_Handle result = Dart_ListLength(lib_ids, &len);
if (Dart_IsError(result)) {
return result;
}
for (intptr_t i = 0; i < len; i++) {
- Dart_Handle lib_url = Dart_ListGetAt(lib_urls, i);
+ Dart_Handle lib_id = Dart_ListGetAt(lib_ids, i);
+ int64_t id64;
+ Dart_IntegerToInt64(lib_id, &id64);
+ Dart_Handle lib_url = Dart_GetLibraryURL(id64);
+ if (Dart_IsError(lib_url)) {
+ return lib_url;
+ }
Dart_Handle lib = Dart_LookupLibrary(lib_url);
if (Dart_IsError(lib)) {
return lib;
« no previous file with comments | « runtime/include/dart_debugger_api.h ('k') | runtime/vm/debugger_api_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698