Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: gyp/images.gyp

Issue 14029011: Include gif image decoding in images/ on linux. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Respond to nit Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/skimage_main.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/images.gyp
diff --git a/gyp/images.gyp b/gyp/images.gyp
index b5d0334fa67fd258bf6a45bb8becee41f843ef3d..93e95a42c1612d66b20bfdc1b68d569a2fc66fa0 100644
--- a/gyp/images.gyp
+++ b/gyp/images.gyp
@@ -97,12 +97,7 @@
],
}],
[ 'skia_os in ["linux", "freebsd", "openbsd", "solaris", "nacl"]', {
- 'sources!': [
- '../src/images/SkImageDecoder_libgif.cpp',
- '../src/images/SkMovie_gif.cpp',
- ],
- # libpng stuff:
- # Any targets that depend on this target should link in libpng and
+ # Any targets that depend on this target should link in libpng, libgif, and
# our code that calls it.
# See http://code.google.com/p/gyp/wiki/InputFormatReference#Dependent_Settings
'link_settings': {
@@ -110,11 +105,12 @@
'../src/images/SkImageDecoder_libpng.cpp',
],
'libraries': [
+ '-lgif',
'-lpng',
'-lz',
],
},
- # end libpng stuff
+ # end libpng/libgif stuff
}],
[ 'skia_os == "android"', {
'include_dirs': [
« no previous file with comments | « no previous file | tools/skimage_main.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698