Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 14029011: Include gif image decoding in images/ on linux. (Closed)

Created:
7 years, 8 months ago by scroggo
Modified:
7 years, 8 months ago
Reviewers:
djsollen, Stephen White
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Include gif image decoding in images/ on linux. Build SkImageDecoder_libgif in images project and link against libgif on linux. Ensure that the GIF decoder is used in skimage. Requires a new dependency on libgif-dev when building on linux. Committed: https://code.google.com/p/skia/source/detail?r=8627

Patch Set 1 #

Total comments: 3

Patch Set 2 : Respond to nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M gyp/images.gyp View 1 2 chunks +3 lines, -7 lines 0 comments Download
M tools/skimage_main.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scroggo
https://codereview.chromium.org/14029011/diff/1/gyp/images.gyp File gyp/images.gyp (right): https://codereview.chromium.org/14029011/diff/1/gyp/images.gyp#newcode105 gyp/images.gyp:105: '../src/images/SkImageDecoder_libpng.cpp', senorblanco@, it looks like you added this line. ...
7 years, 8 months ago (2013-04-11 16:50:56 UTC) #1
Stephen White
On 2013/04/11 16:50:56, scroggo wrote: > https://codereview.chromium.org/14029011/diff/1/gyp/images.gyp > File gyp/images.gyp (right): > > https://codereview.chromium.org/14029011/diff/1/gyp/images.gyp#newcode105 > ...
7 years, 8 months ago (2013-04-11 17:22:03 UTC) #2
djsollen
lgtm with one nit https://codereview.chromium.org/14029011/diff/1/gyp/images.gyp File gyp/images.gyp (right): https://codereview.chromium.org/14029011/diff/1/gyp/images.gyp#newcode100 gyp/images.gyp:100: # Any targets that depend ...
7 years, 8 months ago (2013-04-11 18:25:33 UTC) #3
scroggo
https://codereview.chromium.org/14029011/diff/1/gyp/images.gyp File gyp/images.gyp (right): https://codereview.chromium.org/14029011/diff/1/gyp/images.gyp#newcode100 gyp/images.gyp:100: # Any targets that depend on this target should ...
7 years, 8 months ago (2013-04-11 18:31:47 UTC) #4
scroggo
7 years, 8 months ago (2013-04-11 18:32:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r8627 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698