Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2150)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_state_unittest.cc

Issue 1402803002: [Password Manager] Pass origin of the form which was autofilled in order to display it in managemen… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_state_unittest.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_state_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_state_unittest.cc
index cff7239a5d8c43eb21b902817d54144808fe9f8e..aa84354e0996dd6079992c85fd3485427e53d1ed 100644
--- a/chrome/browser/ui/passwords/manage_passwords_state_unittest.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_state_unittest.cc
@@ -349,13 +349,14 @@ TEST_F(ManagePasswordsStateTest, PasswordAutofilled) {
password_form_map.insert(
test_local_form().username_value,
make_scoped_ptr(new autofill::PasswordForm(test_local_form())));
- passwords_data().OnPasswordAutofilled(password_form_map);
+ GURL origin("https://example.com");
+ passwords_data().OnPasswordAutofilled(password_form_map, origin);
EXPECT_THAT(passwords_data().GetCurrentForms(),
ElementsAre(Pointee(test_local_form())));
EXPECT_THAT(passwords_data().federated_credentials_forms(), IsEmpty());
EXPECT_EQ(password_manager::ui::MANAGE_STATE, passwords_data().state());
- EXPECT_EQ(test_local_form().origin, passwords_data().origin());
+ EXPECT_EQ(origin, passwords_data().origin());
// |passwords_data| should hold a separate copy of test_local_form().
EXPECT_THAT(passwords_data().GetCurrentForms(),
@@ -370,7 +371,8 @@ TEST_F(ManagePasswordsStateTest, InactiveOnPSLMatched) {
password_form_map.insert(
psl_matched_test_form.username_value,
make_scoped_ptr(new autofill::PasswordForm(psl_matched_test_form)));
- passwords_data().OnPasswordAutofilled(password_form_map);
+ passwords_data().OnPasswordAutofilled(password_form_map,
+ GURL("https://m.example.com/"));
EXPECT_THAT(passwords_data().GetCurrentForms(), IsEmpty());
EXPECT_THAT(passwords_data().federated_credentials_forms(), IsEmpty());
@@ -454,7 +456,8 @@ TEST_F(ManagePasswordsStateTest, BackgroundAutofilledAddBlacklisted) {
password_form_map.insert(
test_local_form().username_value,
make_scoped_ptr(new autofill::PasswordForm(test_local_form())));
- passwords_data().OnPasswordAutofilled(password_form_map);
+ passwords_data().OnPasswordAutofilled(
+ password_form_map, password_form_map.begin()->second->origin);
EXPECT_EQ(password_manager::ui::MANAGE_STATE, passwords_data().state());
TestBlacklistedUpdates();
« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_state.cc ('k') | chrome/browser/ui/passwords/manage_passwords_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698