components/password_manager/core/browser/password_manager.cc - Issue 1402803002: [Password Manager] Pass origin of the form which was autofilled in order to display it in managemen…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 1402803002: [Password Manager] Pass origin of the form which was autofilled in order to display it in managemen… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc ('K') | « chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc ('k') | components/password_manager/core/browser/password_manager_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager.cc

diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc

index d55849868e5d709f64fa1ef477a50333bf2f691e..b609e6fb3aeedd789fae1cea0e1b0f7955cd9c95 100644

--- a/components/password_manager/core/browser/password_manager.cc

+++ b/components/password_manager/core/browser/password_manager.cc

@@ -740,7 +740,7 @@ void PasswordManager::Autofill(password_manager::PasswordManagerDriver* driver,

PreferredRealmIsFromAndroid(fill_data));

driver->FillPasswordForm(fill_data);

- client_->PasswordWasAutofilled(best_matches);

+ client_->PasswordWasAutofilled(best_matches, form_for_autofill.origin);

}

void PasswordManager::AutofillHttpAuth(

@@ -758,8 +758,9 @@ void PasswordManager::AutofillHttpAuth(

FOR_EACH_OBSERVER(LoginModelObserver, observers_,

OnAutofillDataAvailable(preferred_match));

- client_->PasswordWasAutofilled(best_matches);

+ DCHECK(!best_matches.empty());

+ client_->PasswordWasAutofilled(best_matches,

+ best_matches.begin()->second->origin);

}

void PasswordManager::ProcessAutofillPredictions(