Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

Issue 1402803002: [Password Manager] Pass origin of the form which was autofilled in order to display it in managemen… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/prefs/pref_service.h" 6 #include "base/prefs/pref_service.h"
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "base/time/time.h" 8 #include "base/time/time.h"
9 #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h" 9 #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"
10 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.h" 10 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.h"
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 ExpectIconStateIs(password_manager::ui::INACTIVE_STATE); 227 ExpectIconStateIs(password_manager::ui::INACTIVE_STATE);
228 } 228 }
229 229
230 TEST_F(ManagePasswordsUIControllerTest, PasswordAutofilled) { 230 TEST_F(ManagePasswordsUIControllerTest, PasswordAutofilled) {
231 scoped_ptr<autofill::PasswordForm> test_form( 231 scoped_ptr<autofill::PasswordForm> test_form(
232 new autofill::PasswordForm(test_local_form())); 232 new autofill::PasswordForm(test_local_form()));
233 autofill::PasswordForm* test_form_ptr = test_form.get(); 233 autofill::PasswordForm* test_form_ptr = test_form.get();
234 base::string16 kTestUsername = test_form->username_value; 234 base::string16 kTestUsername = test_form->username_value;
235 autofill::PasswordFormMap map; 235 autofill::PasswordFormMap map;
236 map.insert(kTestUsername, test_form.Pass()); 236 map.insert(kTestUsername, test_form.Pass());
237 controller()->OnPasswordAutofilled(map); 237 controller()->OnPasswordAutofilled(map, map.begin()->second->origin);
238 238
239 EXPECT_EQ(password_manager::ui::MANAGE_STATE, controller()->state()); 239 EXPECT_EQ(password_manager::ui::MANAGE_STATE, controller()->state());
240 EXPECT_FALSE(controller()->PasswordPendingUserDecision()); 240 EXPECT_FALSE(controller()->PasswordPendingUserDecision());
241 EXPECT_EQ(test_form_ptr->origin, controller()->origin()); 241 EXPECT_EQ(test_form_ptr->origin, controller()->origin());
242 ASSERT_EQ(1u, controller()->GetCurrentForms().size()); 242 ASSERT_EQ(1u, controller()->GetCurrentForms().size());
243 EXPECT_EQ(kTestUsername, controller()->GetCurrentForms()[0]->username_value); 243 EXPECT_EQ(kTestUsername, controller()->GetCurrentForms()[0]->username_value);
244 244
245 // Controller should store a separate copy of the form as it doesn't own it. 245 // Controller should store a separate copy of the form as it doesn't own it.
246 EXPECT_NE(test_form_ptr, controller()->GetCurrentForms()[0]); 246 EXPECT_NE(test_form_ptr, controller()->GetCurrentForms()[0]);
247 247
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
374 EXPECT_FALSE(controller()->PasswordPendingUserDecision()); 374 EXPECT_FALSE(controller()->PasswordPendingUserDecision());
375 375
376 ExpectIconStateIs(password_manager::ui::INACTIVE_STATE); 376 ExpectIconStateIs(password_manager::ui::INACTIVE_STATE);
377 } 377 }
378 378
379 TEST_F(ManagePasswordsUIControllerTest, BlacklistedElsewhere) { 379 TEST_F(ManagePasswordsUIControllerTest, BlacklistedElsewhere) {
380 base::string16 kTestUsername = base::ASCIIToUTF16("test_username"); 380 base::string16 kTestUsername = base::ASCIIToUTF16("test_username");
381 autofill::PasswordFormMap map; 381 autofill::PasswordFormMap map;
382 map.insert(kTestUsername, 382 map.insert(kTestUsername,
383 make_scoped_ptr(new autofill::PasswordForm(test_local_form()))); 383 make_scoped_ptr(new autofill::PasswordForm(test_local_form())));
384 controller()->OnPasswordAutofilled(map); 384 controller()->OnPasswordAutofilled(map, map.begin()->second->origin);
385 385
386 test_local_form().blacklisted_by_user = true; 386 test_local_form().blacklisted_by_user = true;
387 password_manager::PasswordStoreChange change( 387 password_manager::PasswordStoreChange change(
388 password_manager::PasswordStoreChange::ADD, test_local_form()); 388 password_manager::PasswordStoreChange::ADD, test_local_form());
389 password_manager::PasswordStoreChangeList list(1, change); 389 password_manager::PasswordStoreChangeList list(1, change);
390 controller()->OnLoginsChanged(list); 390 controller()->OnLoginsChanged(list);
391 391
392 EXPECT_EQ(password_manager::ui::MANAGE_STATE, controller()->state()); 392 EXPECT_EQ(password_manager::ui::MANAGE_STATE, controller()->state());
393 EXPECT_EQ(test_local_form().origin, controller()->origin()); 393 EXPECT_EQ(test_local_form().origin, controller()->origin());
394 394
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
554 TEST_F(ManagePasswordsUIControllerTest, AutofillDuringAutoSignin) { 554 TEST_F(ManagePasswordsUIControllerTest, AutofillDuringAutoSignin) {
555 ScopedVector<autofill::PasswordForm> local_credentials; 555 ScopedVector<autofill::PasswordForm> local_credentials;
556 local_credentials.push_back(new autofill::PasswordForm(test_local_form())); 556 local_credentials.push_back(new autofill::PasswordForm(test_local_form()));
557 controller()->OnAutoSignin(local_credentials.Pass()); 557 controller()->OnAutoSignin(local_credentials.Pass());
558 ExpectIconAndControllerStateIs(password_manager::ui::AUTO_SIGNIN_STATE); 558 ExpectIconAndControllerStateIs(password_manager::ui::AUTO_SIGNIN_STATE);
559 scoped_ptr<autofill::PasswordForm> test_form( 559 scoped_ptr<autofill::PasswordForm> test_form(
560 new autofill::PasswordForm(test_local_form())); 560 new autofill::PasswordForm(test_local_form()));
561 autofill::PasswordFormMap map; 561 autofill::PasswordFormMap map;
562 base::string16 kTestUsername = test_form->username_value; 562 base::string16 kTestUsername = test_form->username_value;
563 map.insert(kTestUsername, test_form.Pass()); 563 map.insert(kTestUsername, test_form.Pass());
564 controller()->OnPasswordAutofilled(map); 564 controller()->OnPasswordAutofilled(map, map.begin()->second->origin);
565 565
566 ExpectIconAndControllerStateIs(password_manager::ui::AUTO_SIGNIN_STATE); 566 ExpectIconAndControllerStateIs(password_manager::ui::AUTO_SIGNIN_STATE);
567 } 567 }
568 568
569 TEST_F(ManagePasswordsUIControllerTest, InactiveOnPSLMatched) { 569 TEST_F(ManagePasswordsUIControllerTest, InactiveOnPSLMatched) {
570 base::string16 kTestUsername = base::ASCIIToUTF16("test_username"); 570 base::string16 kTestUsername = base::ASCIIToUTF16("test_username");
571 autofill::PasswordFormMap map; 571 autofill::PasswordFormMap map;
572 scoped_ptr<autofill::PasswordForm> psl_matched_test_form( 572 scoped_ptr<autofill::PasswordForm> psl_matched_test_form(
573 new autofill::PasswordForm(test_local_form())); 573 new autofill::PasswordForm(test_local_form()));
574 psl_matched_test_form->is_public_suffix_match = true; 574 psl_matched_test_form->is_public_suffix_match = true;
575 map.insert(kTestUsername, psl_matched_test_form.Pass()); 575 map.insert(kTestUsername, psl_matched_test_form.Pass());
576 controller()->OnPasswordAutofilled(map); 576 controller()->OnPasswordAutofilled(map, map.begin()->second->origin);
577 577
578 EXPECT_EQ(password_manager::ui::INACTIVE_STATE, controller()->state()); 578 EXPECT_EQ(password_manager::ui::INACTIVE_STATE, controller()->state());
579 } 579 }
580 580
581 TEST_F(ManagePasswordsUIControllerTest, UpdatePasswordSubmitted) { 581 TEST_F(ManagePasswordsUIControllerTest, UpdatePasswordSubmitted) {
582 scoped_ptr<password_manager::PasswordFormManager> test_form_manager( 582 scoped_ptr<password_manager::PasswordFormManager> test_form_manager(
583 CreateFormManager()); 583 CreateFormManager());
584 controller()->OnUpdatePasswordSubmitted(test_form_manager.Pass()); 584 controller()->OnUpdatePasswordSubmitted(test_form_manager.Pass());
585 EXPECT_EQ(password_manager::ui::PENDING_PASSWORD_UPDATE_STATE, 585 EXPECT_EQ(password_manager::ui::PENDING_PASSWORD_UPDATE_STATE,
586 controller()->state()); 586 controller()->state());
587 587
588 ExpectIconStateIs(password_manager::ui::PENDING_PASSWORD_UPDATE_STATE); 588 ExpectIconStateIs(password_manager::ui::PENDING_PASSWORD_UPDATE_STATE);
589 } 589 }
590 590
591 TEST_F(ManagePasswordsUIControllerTest, PasswordUpdated) { 591 TEST_F(ManagePasswordsUIControllerTest, PasswordUpdated) {
592 scoped_ptr<password_manager::PasswordFormManager> test_form_manager( 592 scoped_ptr<password_manager::PasswordFormManager> test_form_manager(
593 CreateFormManager()); 593 CreateFormManager());
594 test_form_manager->ProvisionallySave( 594 test_form_manager->ProvisionallySave(
595 test_local_form(), 595 test_local_form(),
596 password_manager::PasswordFormManager::IGNORE_OTHER_POSSIBLE_USERNAMES); 596 password_manager::PasswordFormManager::IGNORE_OTHER_POSSIBLE_USERNAMES);
597 controller()->OnUpdatePasswordSubmitted(test_form_manager.Pass()); 597 controller()->OnUpdatePasswordSubmitted(test_form_manager.Pass());
598 598
599 ExpectIconStateIs(password_manager::ui::PENDING_PASSWORD_UPDATE_STATE); 599 ExpectIconStateIs(password_manager::ui::PENDING_PASSWORD_UPDATE_STATE);
600 controller()->UpdatePassword(autofill::PasswordForm()); 600 controller()->UpdatePassword(autofill::PasswordForm());
601 ExpectIconStateIs(password_manager::ui::MANAGE_STATE); 601 ExpectIconStateIs(password_manager::ui::MANAGE_STATE);
602 } 602 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698