Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Side by Side Diff: chrome/browser/ui/passwords/manage_passwords_state.cc

Issue 1402803002: [Password Manager] Pass origin of the form which was autofilled in order to display it in managemen… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/passwords/manage_passwords_state.h" 5 #include "chrome/browser/ui/passwords/manage_passwords_state.h"
6 6
7 #include "components/password_manager/core/browser/browser_save_password_progres s_logger.h" 7 #include "components/password_manager/core/browser/browser_save_password_progres s_logger.h"
8 #include "components/password_manager/core/browser/password_form_manager.h" 8 #include "components/password_manager/core/browser/password_form_manager.h"
9 #include "components/password_manager/core/browser/password_manager_client.h" 9 #include "components/password_manager/core/browser/password_manager_client.h"
10 #include "components/password_manager/core/common/credential_manager_types.h" 10 #include "components/password_manager/core/common/credential_manager_types.h"
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 current_forms.insert(form_manager_->best_matches().begin(), 138 current_forms.insert(form_manager_->best_matches().begin(),
139 form_manager_->best_matches().end()); 139 form_manager_->best_matches().end());
140 current_forms[form_manager_->pending_credentials().username_value] = 140 current_forms[form_manager_->pending_credentials().username_value] =
141 &form_manager_->pending_credentials(); 141 &form_manager_->pending_credentials();
142 current_forms_weak_ = MapToVector(current_forms); 142 current_forms_weak_ = MapToVector(current_forms);
143 origin_ = form_manager_->pending_credentials().origin; 143 origin_ = form_manager_->pending_credentials().origin;
144 SetState(password_manager::ui::CONFIRMATION_STATE); 144 SetState(password_manager::ui::CONFIRMATION_STATE);
145 } 145 }
146 146
147 void ManagePasswordsState::OnPasswordAutofilled( 147 void ManagePasswordsState::OnPasswordAutofilled(
148 const PasswordFormMap& password_form_map) { 148 const PasswordFormMap& password_form_map,
149 const GURL& origin) {
149 // TODO(vabr): Revert back to DCHECK once http://crbug.com/486931 is fixed. 150 // TODO(vabr): Revert back to DCHECK once http://crbug.com/486931 is fixed.
150 CHECK(!password_form_map.empty()); 151 CHECK(!password_form_map.empty());
151 ClearData(); 152 ClearData();
152 if (password_form_map.begin()->second->is_public_suffix_match) { 153 if (password_form_map.begin()->second->is_public_suffix_match) {
153 // Don't show the UI for PSL matched passwords. They are not stored for this 154 // Don't show the UI for PSL matched passwords. They are not stored for this
154 // page and cannot be deleted. 155 // page and cannot be deleted.
155 origin_ = GURL(); 156 origin_ = GURL();
156 SetState(password_manager::ui::INACTIVE_STATE); 157 SetState(password_manager::ui::INACTIVE_STATE);
157 } else { 158 } else {
158 local_credentials_forms_ = DeepCopyMapToVector(password_form_map); 159 local_credentials_forms_ = DeepCopyMapToVector(password_form_map);
159 origin_ = local_credentials_forms_.front()->origin; 160 origin_ = origin;
160 SetState(password_manager::ui::MANAGE_STATE); 161 SetState(password_manager::ui::MANAGE_STATE);
161 } 162 }
162 } 163 }
163 164
164 void ManagePasswordsState::OnInactive() { 165 void ManagePasswordsState::OnInactive() {
165 ClearData(); 166 ClearData();
166 origin_ = GURL(); 167 origin_ = GURL();
167 SetState(password_manager::ui::INACTIVE_STATE); 168 SetState(password_manager::ui::INACTIVE_STATE);
168 } 169 }
169 170
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
254 void ManagePasswordsState::SetState(password_manager::ui::State state) { 255 void ManagePasswordsState::SetState(password_manager::ui::State state) {
255 DCHECK(client_); 256 DCHECK(client_);
256 if (client_->IsLoggingActive()) { 257 if (client_->IsLoggingActive()) {
257 password_manager::BrowserSavePasswordProgressLogger logger(client_); 258 password_manager::BrowserSavePasswordProgressLogger logger(client_);
258 logger.LogNumber( 259 logger.LogNumber(
259 autofill::SavePasswordProgressLogger::STRING_NEW_UI_STATE, 260 autofill::SavePasswordProgressLogger::STRING_NEW_UI_STATE,
260 state); 261 state);
261 } 262 }
262 state_ = state; 263 state_ = state;
263 } 264 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_state.h ('k') | chrome/browser/ui/passwords/manage_passwords_state_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698