Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 14028022: Revert 195389 "url: Copy 'googleurl_unittests' target from 'url_..." (Closed)

Created:
7 years, 8 months ago by gavinp
Modified:
7 years, 8 months ago
Reviewers:
tfarina
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 195389 "url: Copy 'googleurl_unittests' target from 'url_..." > url: Copy 'googleurl_unittests' target from 'url_unittests'. Attempt 2. > > To not break the buildbot, this creates a fake target that copies url_unittests > to googleurl_unittests as temporary scaffolding. > > BUG=229660 > R=brettw@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/14199009 TBR=tfarina@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195392

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -80 lines) Patch
M trunk/src/build/all.gyp View 11 chunks +18 lines, -18 lines 0 comments Download
M trunk/src/url/url.gyp View 1 chunk +0 lines, -62 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
gavinp
7 years, 8 months ago (2013-04-20 12:52:07 UTC) #1
gavinp
7 years, 8 months ago (2013-04-20 12:52:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r195392.

Powered by Google App Engine
This is Rietveld 408576698