Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: Source/bindings/scripts/CodeGeneratorV8.pm

Issue 14028014: Remove MicroData implementation (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Also delete all the tests Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/bindings.gypi ('k') | Source/bindings/v8/custom/V8HTMLCollectionCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/CodeGeneratorV8.pm
diff --git a/Source/bindings/scripts/CodeGeneratorV8.pm b/Source/bindings/scripts/CodeGeneratorV8.pm
index dbb1c56a26978f9f8378e0c343b7f91931113a41..4efa6d847bc6cb9a98695c10a2185ce5f30f6d8a 100644
--- a/Source/bindings/scripts/CodeGeneratorV8.pm
+++ b/Source/bindings/scripts/CodeGeneratorV8.pm
@@ -2738,12 +2738,7 @@ END
$hasEnumerator = 0;
}
- # FIXME: implement V8HTMLPropertiesCollection::namedPropertyGetter
- if ($interfaceName eq "HTMLPropertiesCollection") {
- push(@implContent, " desc->${setOn}Template()->SetNamedPropertyHandler(V8HTMLCollection::namedPropertyGetter, ");
- } else {
- push(@implContent, " desc->${setOn}Template()->SetNamedPropertyHandler(${v8InterfaceName}::namedPropertyGetter, ");
- }
+ push(@implContent, " desc->${setOn}Template()->SetNamedPropertyHandler(${v8InterfaceName}::namedPropertyGetter, ");
push(@implContent, $hasCustomNamedSetter ? "${v8InterfaceName}::namedPropertySetter, " : "0, ");
# If there is a custom enumerator, there MUST be custom query to properly communicate property attributes.
push(@implContent, $hasEnumerator ? "${v8InterfaceName}::namedPropertyQuery, " : "0, ");
@@ -2961,12 +2956,6 @@ END
if ($function->signature->name eq "item") {
$indexer = $function->signature;
- }
-
- if ($interfaceName eq "HTMLPropertiesCollection") {
- if ($function->signature->name eq "propertyNodeList") {
- $namedPropertyGetter = $function->signature;
- }
} elsif ($function->signature->name eq "namedItem") {
$namedPropertyGetter = $function->signature;
}
« no previous file with comments | « Source/bindings/bindings.gypi ('k') | Source/bindings/v8/custom/V8HTMLCollectionCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698