third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 1402793002: RoundOff scrollableArea scrollHeight.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 1402793002: RoundOff scrollableArea scrollHeight. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added text expectations for mac and win Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index 2852e51bd4b59ce7431c9bd8e6d5d0a9d1c4897d..0d39ca0b9a45feeaf33205b959f5e4c410be1f59 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -455,7 +455,7 @@ int LayoutBox::pixelSnappedScrollWidth() const

int LayoutBox::pixelSnappedScrollHeight() const

{

if (hasOverflowClip())

- return layer()->scrollableArea()->scrollHeight();

+ return snapSizeToPixel(layer()->scrollableArea()->scrollHeight(), location().y() + clientTop());

// For objects with visible overflow, this matches IE.

// FIXME: Need to work right with writing modes.

return snapSizeToPixel(scrollHeight(), location().y() + clientTop());