RoundOff scrollableArea scrollHeight.

RoundOff scrollableArea scrollHeight.

RoundOff scrollableArea scrollHeight.On RootLayerScrolls scrollablearea
scrollheight is returned by pixelSnappedScrollHeight.The value needs to
be rounded else we are getting the scrollHeight difference by 1px.

BUG=522389
TESTED=scrollbars/custom-scrollbar-with-incomplete-style.html
now passes with root layer scrolling

Committed: https://crrev.com/1d0c0da5fa6041b4cf6054c06bcb3a0e4179f006
Cr-Commit-Position: refs/heads/master@{#353985}

[MuVen, 2015-10-12 14:34:36]

sataya.m@samsung.com changed reviewers:
+ skobes@chromium.org

[MuVen, 2015-10-12 14:39:51]

Hi Skobes, 

without --root-layer-scrolls 
LayoutView #document pixelSnappedScrollHeight:1412 
layer at (0,0) size 800x600 clip at (0,0) size 787x600 scrollHeight 1412

with --root-layer-scrolls
LayoutView #document pixelSnappedScrollHeight:1411.906250
layer at (0,0) size 800x600 clip at (0,0) size 787x600 scrollHeight 1411

with --root-layer-scrolls we return layer()->scrollableArea()->scrollHeight()
whose value needs to be rounded off. I have used the 
snapSizeToPixel(layer()->scrollableArea()->scrollHeight(), location().y() +
clientTop());
as used snapSizeToPixel(scrollHeight(), location().y() + clientTop()); 
and also roundToInt(layer()->scrollableArea()->scrollHeight()). Both works !!!
Please share your inputs.

Thanks,
MuVen !!!

[skobes, 2015-10-12 18:16:48]

lgtm

Nice find.

[MuVen, 2015-10-13 03:05:26]

The CQ bit was checked by sataya.m@samsung.com

[commit-bot: I haz the power, 2015-10-13 03:05:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1402793002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1402793002/1

[commit-bot: I haz the power, 2015-10-13 04:11:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-13 04:11:12]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[MuVen, 2015-10-13 11:39:52]

Patchset #2 (id:20001) has been deleted

[MuVen, 2015-10-13 11:40:05]

Patchset #3 (id:60001) has been deleted

[MuVen, 2015-10-13 11:40:15]

Patchset #3 (id:80001) has been deleted

[MuVen, 2015-10-13 11:40:24]

Patchset #3 (id:100001) has been deleted

[MuVen, 2015-10-13 11:40:32]

Patchset #3 (id:120001) has been deleted

[MuVen, 2015-10-13 11:40:42]

Patchset #3 (id:140001) has been deleted

[MuVen, 2015-10-13 11:40:50]

Patchset #3 (id:160001) has been deleted

[MuVen, 2015-10-13 11:40:59]

Patchset #3 (id:180001) has been deleted

[MuVen, 2015-10-13 13:25:32]

Patchset #5 (id:230001) has been deleted

[MuVen, 2015-10-13 14:17:37]

Patchset #4 (id:210001) has been deleted

[MuVen, 2015-10-13 14:17:47]

Patchset #3 (id:190001) has been deleted

[MuVen, 2015-10-13 14:18:01]

Patchset #2 (id:40001) has been deleted

[MuVen, 2015-10-13 15:52:02]

Skobes, PTAL. I have added test exceptions.

[MuVen, 2015-10-13 16:09:32]

The CQ bit was checked by sataya.m@samsung.com

[MuVen, 2015-10-13 16:09:32]

The patchset sent to the CQ was uploaded after l-g-t-m from skobes@chromium.org
Link to the patchset: https://codereview.chromium.org/1402793002/#ps290001
(title: "added text expectations for mac and win")

[MuVen, 2015-10-13 16:10:07]

The CQ bit was unchecked by sataya.m@samsung.com

[MuVen, 2015-10-13 16:10:44]

The CQ bit was checked by sataya.m@samsung.com

[MuVen, 2015-10-13 16:12:25]

The CQ bit was unchecked by sataya.m@samsung.com

[skobes, 2015-10-13 20:41:10]

https://codereview.chromium.org/1402793002/diff/290001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/1402793002/diff/290001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/TestExpectations:1006: crbug.com/509025 [
Yosemite Mac ] fast/forms/hidden-listbox.html [ Failure NeedsRebaseline ]
This isn't correct, what you want is to rebaseline all the non-Yosemite Mac
versions.  Keep the Yosemite expectation as "Failure" and add another line like

crbug.com/509025 [ SnowLeopard Lion MountainLion Retina Mavericks ]
fast/forms/hidden-listbox.html [ NeedsRebaseline ]

You can see the full list of tokens at
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit....

We are planning to support excluding platforms so in the future you will be able
to just say "Mac -Yosemite".  But for now you have to list them all. :)

https://codereview.chromium.org/1402793002/diff/290001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/compositing/overflow/nested-render-surfaces-with-rotation-expected.txt
(right):

https://codereview.chromium.org/1402793002/diff/290001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/compositing/overflow/nested-render-surfaces-with-rotation-expected.txt:10:
layer at (8,120) size 308x308 clip at (12,124) size 285x285 scrollWidth 339
scrollHeight 448
Why do we need to manually update the expectations here?  If you mark them all
as NeedsRebaseline the auto-rebaseline bot should make all the necessary
updates.

[MuVen, 2015-10-14 08:01:20]

The CQ bit was checked by sataya.m@samsung.com

[MuVen, 2015-10-14 08:01:21]

The patchset sent to the CQ was uploaded after l-g-t-m from skobes@chromium.org
Link to the patchset: https://codereview.chromium.org/1402793002/#ps370001
(title: " ")

[MuVen, 2015-10-14 08:01:25]

The CQ bit was checked by sataya.m@samsung.com

[commit-bot: I haz the power, 2015-10-14 08:01:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1402793002/370001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1402793002/370001

[MuVen, 2015-10-14 08:02:12]

The CQ bit was unchecked by sataya.m@samsung.com

[MuVen, 2015-10-14 08:14:25]

PTAL

https://codereview.chromium.org/1402793002/diff/290001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/1402793002/diff/290001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/TestExpectations:1006: crbug.com/509025 [
Yosemite Mac ] fast/forms/hidden-listbox.html [ Failure NeedsRebaseline ]
On 2015/10/13 20:41:10, skobes wrote:
> This isn't correct, what you want is to rebaseline all the non-Yosemite Mac
> versions.  Keep the Yosemite expectation as "Failure" and add another line
like
> 
> crbug.com/509025 [ SnowLeopard Lion MountainLion Retina Mavericks ]
> fast/forms/hidden-listbox.html [ NeedsRebaseline ]
> 
> You can see the full list of tokens at
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit....
> 
> We are planning to support excluding platforms so in the future you will be
able
> to just say "Mac -Yosemite".  But for now you have to list them all. :)

Done.

https://codereview.chromium.org/1402793002/diff/290001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/compositing/overflow/nested-render-surfaces-with-rotation-expected.txt
(right):

https://codereview.chromium.org/1402793002/diff/290001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/compositing/overflow/nested-render-surfaces-with-rotation-expected.txt:10:
layer at (8,120) size 308x308 clip at (12,124) size 285x285 scrollWidth 339
scrollHeight 448
On 2015/10/13 20:41:10, skobes wrote:
> Why do we need to manually update the expectations here?  If you mark them all
> as NeedsRebaseline the auto-rebaseline bot should make all the necessary
> updates.

i haven't manually updated these values. I have reseted the linux failed test
cases.
anyways i have added these linux test exceptions you suggested.
Done.

[MuVen, 2015-10-14 08:15:50]

The CQ bit was checked by sataya.m@samsung.com

[MuVen, 2015-10-14 08:15:51]

The CQ bit was unchecked by sataya.m@samsung.com

[MuVen, 2015-10-14 08:19:58]

On 2015/10/14 08:14:25, MuVen wrote:
> PTAL
> 
>
https://codereview.chromium.org/1402793002/diff/290001/third_party/WebKit/Lay...
> File third_party/WebKit/LayoutTests/TestExpectations (right):
> 
>
https://codereview.chromium.org/1402793002/diff/290001/third_party/WebKit/Lay...
> third_party/WebKit/LayoutTests/TestExpectations:1006: crbug.com/509025 [
> Yosemite Mac ] fast/forms/hidden-listbox.html [ Failure NeedsRebaseline ]
> On 2015/10/13 20:41:10, skobes wrote:
> > This isn't correct, what you want is to rebaseline all the non-Yosemite Mac
> > versions.  Keep the Yosemite expectation as "Failure" and add another line
> like
> > 
> > crbug.com/509025 [ SnowLeopard Lion MountainLion Retina Mavericks ]
> > fast/forms/hidden-listbox.html [ NeedsRebaseline ]
> > 
> > You can see the full list of tokens at
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit....
> > 
> > We are planning to support excluding platforms so in the future you will be
> able
> > to just say "Mac -Yosemite".  But for now you have to list them all. :)
> 
> Done.
> 
>
https://codereview.chromium.org/1402793002/diff/290001/third_party/WebKit/Lay...
> File
>
third_party/WebKit/LayoutTests/compositing/overflow/nested-render-surfaces-with-rotation-expected.txt
> (right):
> 
>
https://codereview.chromium.org/1402793002/diff/290001/third_party/WebKit/Lay...
>
third_party/WebKit/LayoutTests/compositing/overflow/nested-render-surfaces-with-rotation-expected.txt:10:
> layer at (8,120) size 308x308 clip at (12,124) size 285x285 scrollWidth 339
> scrollHeight 448
> On 2015/10/13 20:41:10, skobes wrote:
> > Why do we need to manually update the expectations here?  If you mark them
all
> > as NeedsRebaseline the auto-rebaseline bot should make all the necessary
> > updates.
> 
> i haven't manually updated these values. I have reseted the linux failed test
> cases.
> anyways i have added these linux test exceptions you suggested.
> Done.

Hi Skobes, 

Im trying to commit this patch, as the test exceptions are changing
continuously.
I have updated as mentioned by you. I hope this should be fine.

Thanks,
MuVen!!!

[MuVen, 2015-10-14 08:20:03]

The CQ bit was checked by sataya.m@samsung.com

[commit-bot: I haz the power, 2015-10-14 08:20:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1402793002/370001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1402793002/370001

[commit-bot: I haz the power, 2015-10-14 09:19:00]

Committed patchset #8 (id:370001)

[commit-bot: I haz the power, 2015-10-14 09:19:37]

Patchset 8 (id:??) landed as
https://crrev.com/1d0c0da5fa6041b4cf6054c06bcb3a0e4179f006
Cr-Commit-Position: refs/heads/master@{#353985}