Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 1402783004: port DDC checker code to analyzer (Closed)

Created:
5 years, 2 months ago by Jennifer Messerly
Modified:
5 years, 2 months ago
Reviewers:
Leaf, Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

port DDC checker code to analyzer It's not used yet, except by its own test. Naturally there's a *lot* to clean up here in follow ups. I tried to keep the ported code in its own directory so it's obvious. Ideally we can remove this directory once the code has been moved out. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/8ae0534c1c7a35e019f8776010f6c53e6a22f6de

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6348 lines, -0 lines) Patch
A pkg/analyzer/lib/src/task/strong/checker.dart View 1 chunk +984 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/task/strong/info.dart View 1 chunk +486 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/task/strong/rules.dart View 1 chunk +770 lines, -0 lines 0 comments Download
A pkg/analyzer/test/src/task/strong/checker_test.dart View 1 chunk +2311 lines, -0 lines 0 comments Download
A pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 1 chunk +1293 lines, -0 lines 0 comments Download
A pkg/analyzer/test/src/task/strong/strong_test_helper.dart View 1 chunk +504 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
5 years, 2 months ago (2015-10-12 19:26:01 UTC) #2
Jennifer Messerly
5 years, 2 months ago (2015-10-12 19:26:13 UTC) #4
Brian Wilkerson
LGTM
5 years, 2 months ago (2015-10-12 19:27:53 UTC) #5
Jennifer Messerly
5 years, 2 months ago (2015-10-12 19:31:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8ae0534c1c7a35e019f8776010f6c53e6a22f6de (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698