Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1402763003: Revert of Stage --harmony_sloppy_function (Closed)

Created:
5 years, 2 months ago by Dan Ehrenberg
Modified:
5 years, 2 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Stage --harmony_sloppy_function (patchset #2 id:20001 of https://codereview.chromium.org/1393423002/ ) Reason for revert: This still breaks Inbox. Original issue's description: > Stage --harmony_sloppy_function > > This patch turns on ES2015-style function hoisting semantics in > staging. --harmony_sloppy_function was previously staged, leading > to a number of bugs being filed and the staging being reversed; > important bugs have been fixed, so it is time to try again. > > R=adamk > LOG=Y > BUG=v8:4285 > > Committed: https://crrev.com/333e27fd99f8187c97e62b9538529900f0a30668 > Cr-Commit-Position: refs/heads/master@{#31190} TBR=adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4285 Committed: https://crrev.com/0c2dff29365672b72b1ebcb7336e807c44a00b99 Cr-Commit-Position: refs/heads/master@{#31206}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M src/flag-definitions.h View 1 chunk +5 lines, -5 lines 0 comments Download
M test/test262/test262.status View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dan Ehrenberg
Created Revert of Stage --harmony_sloppy_function
5 years, 2 months ago (2015-10-12 11:06:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402763003/1
5 years, 2 months ago (2015-10-12 11:06:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-12 11:07:06 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 11:07:33 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c2dff29365672b72b1ebcb7336e807c44a00b99
Cr-Commit-Position: refs/heads/master@{#31206}

Powered by Google App Engine
This is Rietveld 408576698