Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 1402713002: Implement --dump-info for batch mode. (Closed)

Created:
5 years, 2 months ago by devoncarew
Modified:
5 years, 2 months ago
Reviewers:
vsm, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M bin/dartdevc.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M lib/src/compiler.dart View 2 chunks +15 lines, -1 line 1 comment Download

Messages

Total messages: 7 (1 generated)
devoncarew
5 years, 2 months ago (2015-10-12 23:22:20 UTC) #2
Jennifer Messerly
lgtm. As an aside, I've always disliked the name of this option. Both "dump" and ...
5 years, 2 months ago (2015-10-13 00:14:21 UTC) #3
Jennifer Messerly
Oh, FWIW ... I've come close to removing this option on a few occasions. I'd ...
5 years, 2 months ago (2015-10-13 15:26:43 UTC) #4
vsm
lgtm
5 years, 2 months ago (2015-10-13 16:03:51 UTC) #5
devoncarew
On 2015/10/13 15:26:43, John Messerly wrote: > Oh, FWIW ... I've come close to removing ...
5 years, 2 months ago (2015-10-13 16:35:05 UTC) #6
devoncarew
5 years, 2 months ago (2015-10-13 17:31:13 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
10d7d0e795f35780273f8e932686c145b253384e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698