Add sanity check for deprecated component extension IME.

Add sanity check for deprecated component extension IME.

I introduced Input Tools and Google Japanese Input as a experiment, but we may need to remove them.
This CL removes them from active_input_methods if they are removed.

BUG=None
TEST=Manually checked by removing component extension IME.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194360

[satorux1, 2013-04-15 08:31:32]

lgtm with nits:

https://codereview.chromium.org/14027007/diff/6002/chrome/browser/chromeos/in...
File chrome/browser/chromeos/input_method/input_method_manager_impl.cc (right):

https://codereview.chromium.org/14027007/diff/6002/chrome/browser/chromeos/in...
chrome/browser/chromeos/input_method/input_method_manager_impl.cc:351: // We
have to do sanity check here, because some component extension IMEs may
sanity check may be unclear. What about:

Load component extensions but also update |active_input_method_ids_| as some
component extension IMEs may have been removed from the Chrome OS image.

https://codereview.chromium.org/14027007/diff/6002/chrome/browser/chromeos/in...
chrome/browser/chromeos/input_method/input_method_manager_impl.cc:352: // be
removed. So if specified component extension IME is no longer existing,
may be removed -> might have been removed from the Chrome OS image.

IME no longer exists

https://codereview.chromium.org/14027007/diff/6002/chrome/browser/chromeos/in...
chrome/browser/chromeos/input_method/input_method_manager_impl.cc:353: //
falling back to existing IME.
fall back to an existing IME.

https://codereview.chromium.org/14027007/diff/6002/chrome/browser/chromeos/in...
chrome/browser/chromeos/input_method/input_method_manager_impl.cc:360: // Legacy
IMEs or xkb layouts are active alwayes.
always active

[Seigo Nonaka, 2013-04-16 07:17:03]

Thank you for your review.
I will submit with trybot check.

Thank you.

https://codereview.chromium.org/14027007/diff/6002/chrome/browser/chromeos/in...
File chrome/browser/chromeos/input_method/input_method_manager_impl.cc (right):

https://codereview.chromium.org/14027007/diff/6002/chrome/browser/chromeos/in...
chrome/browser/chromeos/input_method/input_method_manager_impl.cc:351: // We
have to do sanity check here, because some component extension IMEs may
On 2013/04/15 08:31:32, satorux1 wrote:
> sanity check may be unclear. What about:
> 
> Load component extensions but also update |active_input_method_ids_| as some
> component extension IMEs may have been removed from the Chrome OS image.

Sure thanks! Done.

https://codereview.chromium.org/14027007/diff/6002/chrome/browser/chromeos/in...
chrome/browser/chromeos/input_method/input_method_manager_impl.cc:352: // be
removed. So if specified component extension IME is no longer existing,
On 2013/04/15 08:31:32, satorux1 wrote:
> may be removed -> might have been removed from the Chrome OS image.
> 
> IME no longer exists

Done.

https://codereview.chromium.org/14027007/diff/6002/chrome/browser/chromeos/in...
chrome/browser/chromeos/input_method/input_method_manager_impl.cc:353: //
falling back to existing IME.
On 2013/04/15 08:31:32, satorux1 wrote:
> fall back to an existing IME.

Done.

https://codereview.chromium.org/14027007/diff/6002/chrome/browser/chromeos/in...
chrome/browser/chromeos/input_method/input_method_manager_impl.cc:360: // Legacy
IMEs or xkb layouts are active alwayes.
On 2013/04/15 08:31:32, satorux1 wrote:
> always active

Done.

[Seigo Nonaka, 2013-04-16 14:18:35]

Committed patchset #5 manually as r194360 (presubmit successful).