Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1115)

Issue 1402693002: Fixed JS custom elements and temporarily mark polymer test as failing (Closed)

Created:
5 years, 2 months ago by terry
Modified:
5 years, 2 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixed JS custom elements and temporarily mark polymer test as failing TBR=alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/4f9771f4e192a4aea5064a4e87008e82674996b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -18 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 7 chunks +20 lines, -9 lines 0 comments Download
M tests/co19/co19-dartium.status View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/src/dartium_CustomElementSupport.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 5 chunks +18 lines, -7 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
terry
Committed patchset #1 (id:1) manually as 4f9771f4e192a4aea5064a4e87008e82674996b6 (presubmit successful).
5 years, 2 months ago (2015-10-10 23:50:18 UTC) #1
Alan Knight
5 years, 2 months ago (2015-10-12 19:43:39 UTC) #2
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698