Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1402653002: cc: Fix ScrollbarLayer overflow (Closed)

Created:
5 years, 2 months ago by no sievers
Modified:
5 years, 2 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Fix ScrollbarLayer overflow During clamping to the max texture size, if scaling saturates scaled_bounds width or height to MAX_INT, then we weren't clamping correctly for bounds().height() > width. BUG=541528 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/99d9eeb9ad625be61df8e960e03284136b2bc769 Cr-Commit-Position: refs/heads/master@{#353633}

Patch Set 1 #

Patch Set 2 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M cc/layers/painted_scrollbar_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
no sievers
ptal
5 years, 2 months ago (2015-10-09 23:45:39 UTC) #2
danakj
Can unit test? LGTM for the change.
5 years, 2 months ago (2015-10-12 21:21:49 UTC) #3
no sievers
On 2015/10/12 21:21:49, danakj wrote: > Can unit test? LGTM for the change. Done.
5 years, 2 months ago (2015-10-12 22:32:47 UTC) #4
danakj
LGTM
5 years, 2 months ago (2015-10-12 22:35:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402653002/20001
5 years, 2 months ago (2015-10-12 22:41:11 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-12 23:57:06 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 23:57:46 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/99d9eeb9ad625be61df8e960e03284136b2bc769
Cr-Commit-Position: refs/heads/master@{#353633}

Powered by Google App Engine
This is Rietveld 408576698