snapshot/win/end_to_end_test.py - Issue 1402643002: Ensure _NT_SYMBOL_PATH is set for bot runs in cdb test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot/win/end_to_end_test.py

Issue 1402643002: Ensure _NT_SYMBOL_PATH is set for bot runs in cdb test (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: . Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: snapshot/win/end_to_end_test.py

diff --git a/snapshot/win/end_to_end_test.py b/snapshot/win/end_to_end_test.py

index 9d8ab27ff3a5f050edcf5560c40dafd56140b77c..48c58a7667d3d3588452f8922f385877fa2ab5d8 100644

--- a/snapshot/win/end_to_end_test.py

+++ b/snapshot/win/end_to_end_test.py

@@ -195,6 +195,12 @@ def main(args):

print >>sys.stderr, 'could not find cdb'

return 1

+ # Make sure we can download Windows symbols.

+ if not os.environ.get('_NT_SYMBOL_PATH'):

+ symbol_dir = MakeTempDir()

+ os.environ['_NT_SYMBOL_PATH'] = (

+ 'SRV*' + symbol_dir + '*https://msdl.microsoft.com/download/symbols')

brucedawson 2015/10/09 23:30:55 Doesn't first-time use of Microsoft's symbol serve

pipe_name = r'\\.\pipe\end-to-end_%s_%s' % (

os.getpid(), str(random.getrandbits(64)))

« no previous file with comments | « no previous file | no next file » | no next file with comments »