Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1402633003: Implement "clear" keyword in SpdyAltSvcWireFormat. (Closed)

Created:
5 years, 2 months ago by Bence
Modified:
5 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement "clear" keyword in SpdyAltSvcWireFormat. Note that the "clear" keyword was introduced to the Alternative Services specification in draft-08. This CL lands server change 104884972 by bnc. BUG=392575 Committed: https://crrev.com/0ddae6a9c18966d68768a792b766a3c9ce74d920 Cr-Commit-Position: refs/heads/master@{#353672}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M net/spdy/spdy_alt_svc_wire_format.h View 2 chunks +4 lines, -1 line 0 comments Download
M net/spdy/spdy_alt_svc_wire_format.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M net/spdy/spdy_alt_svc_wire_format_test.cc View 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Bence
Ryan: PTAL. Thanks.
5 years, 2 months ago (2015-10-12 17:29:40 UTC) #2
Ryan Hamilton
lgtm Do we need a CL at a higher level to ensure that we clear ...
5 years, 2 months ago (2015-10-12 19:55:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402633003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402633003/1
5 years, 2 months ago (2015-10-13 03:53:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-13 03:59:41 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0ddae6a9c18966d68768a792b766a3c9ce74d920 Cr-Commit-Position: refs/heads/master@{#353672}
5 years, 2 months ago (2015-10-13 04:00:46 UTC) #7
Bence
5 years, 2 months ago (2015-10-14 11:59:15 UTC) #8
Message was sent while issue was closed.
On 2015/10/12 19:55:22, Ryan Hamilton wrote:
> lgtm
> 
> Do we need a CL at a higher level to ensure that we clear the A-P mappings?
(Or
> at least a test for this behavior)

I don't believe there's any higher level change needed to make this work. 
http_network_transaction.cc::anonymous namespace::ProcessAlternativeServices()
would pass alternative_service_str = "clear" to
HttpStreamFactory::ProcessAlternativeService(), which in return passes it to
SpdyAltSvcWireFormat::ParseHeaderFieldValue().  From that point, everything is
like before this CL: ParseHeaderFieldValue() returns an empty vector in the
alternative_service_vector outparam, which gets passed to
HttpServerProperties::SetAlternativeServices(), which clears alternative
services for the given origin.

As for a test, yes, that's a swell idea.  I'll work on that.

Powered by Google App Engine
This is Rietveld 408576698