components/password_manager/core/browser/password_store_unittest.cc - Issue 1402553002: Don't use base::MessageLoop::{Quit,QuitClosure} in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store_unittest.cc

Issue 1402553002: Don't use base::MessageLoop::{Quit,QuitClosure} in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/password_manager/core/browser/password_store_unittest.cc

diff --git a/components/password_manager/core/browser/password_store_unittest.cc b/components/password_manager/core/browser/password_store_unittest.cc

index d94445d95416577534e3b6d7fcdfbbf1efb8b733..9f29f15600bd43a2f41e4de02bb1a27d81b590b4 100644

--- a/components/password_manager/core/browser/password_store_unittest.cc

+++ b/components/password_manager/core/browser/password_store_unittest.cc

@@ -386,7 +386,7 @@ TEST_F(PasswordStoreTest, RemoveLoginsCreatedBetweenCallbackIsCalled) {

EXPECT_CALL(mock_observer, OnLoginsChanged(testing::SizeIs(1u)));

store->RemoveLoginsCreatedBetween(

base::Time::FromDoubleT(0), base::Time::FromDoubleT(2),

- base::MessageLoop::current()->QuitClosure());

+ base::MessageLoop::current()->QuitWhenIdleClosure());

base::MessageLoop::current()->Run();

testing::Mock::VerifyAndClearExpectations(&mock_observer);

« no previous file with comments | « components/nacl/broker/nacl_broker_listener.cc ('k') | components/scheduler/base/task_queue_manager_perftest.cc » ('j') | no next file with comments »