Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Unified Diff: Source/core/css/parser/BisonCSSParser-in.cpp

Issue 140253004: Implement 'scroll-behavior' parsing (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/parser/BisonCSSParser-in.cpp
diff --git a/Source/core/css/parser/BisonCSSParser-in.cpp b/Source/core/css/parser/BisonCSSParser-in.cpp
index c73a4b5fc0345e2ea229f455a90b36218af6f37f..49bf76d166192183e967c98085a72b6092278890 100644
--- a/Source/core/css/parser/BisonCSSParser-in.cpp
+++ b/Source/core/css/parser/BisonCSSParser-in.cpp
@@ -575,6 +575,9 @@ static inline bool isValidKeywordPropertyAndValue(CSSPropertyID propertyId, int
if (valueID == CSSValueNone || valueID == CSSValueBoth || valueID == CSSValueHorizontal || valueID == CSSValueVertical || valueID == CSSValueAuto)
return true;
break;
+ case CSSPropertyScrollBehavior: // instant | smooth
+ if (RuntimeEnabledFeatures::cssomSmoothScrollEnabled() && (valueID == CSSValueInstant || valueID == CSSValueSmooth))
Julien - ping for review 2014/01/22 16:24:35 I much prefer to put the following as it underline
ajuma 2014/01/22 19:50:20 Done.
+ return true;
case CSSPropertySpeak: // none | normal | spell-out | digits | literal-punctuation | no-punctuation | inherit
if (valueID == CSSValueNone || valueID == CSSValueNormal || valueID == CSSValueSpellOut || valueID == CSSValueDigits || valueID == CSSValueLiteralPunctuation || valueID == CSSValueNoPunctuation)
return true;
@@ -867,6 +870,7 @@ static inline bool isKeywordPropertyID(CSSPropertyID propertyId)
case CSSPropertyPointerEvents:
case CSSPropertyPosition:
case CSSPropertyResize:
+ case CSSPropertyScrollBehavior:
case CSSPropertySpeak:
case CSSPropertyTableLayout:
case CSSPropertyTextAlignLast:

Powered by Google App Engine
This is Rietveld 408576698