LayoutTests/fast/scroll-behavior/parse-scroll-behavior.html - Issue 140253004: Implement 'scroll-behavior' parsing

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/scroll-behavior/parse-scroll-behavior.html

Issue 140253004: Implement 'scroll-behavior' parsing (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <style>

	5 #scrollBehaviorInstant {

	6 scroll-behavior: instant;

	7 }

	8

	9 #scrollBehaviorSmooth {

	10 scroll-behavior: smooth;

	11 }

	12 </style>

	13 <script src="../../resources/js-test.js"></script>

	14 </head>

	15 <body>

	16 <div id="scrollBehaviorInstant"></div>

	17 <div id="scrollBehaviorSmooth"></div>

	18 <script>

	19 description('Test that setting and getting scroll-behavior works as expected');

	20

	21 debug("Test getting scroll-behavior set through CSS");

	22 var scrollBehaviorInstant = document.getElementById("scrollBehaviorInstant");

	23 shouldBe("getComputedStyle(scrollBehaviorInstant, '').getPropertyValue('scroll-b ehavior')", "'instant'");

	24

	25 var scrollBehaviorSmooth = document.getElementById("scrollBehaviorSmooth");

	26 shouldBe("getComputedStyle(scrollBehaviorSmooth, '').getPropertyValue('scroll-be havior')", "'smooth'");

	27

	28 debug("");

	29 debug("Test initial value of scroll-behavior");

	30 var element = document.createElement("div");

	31 document.body.appendChild(element);

	32 shouldBe("getComputedStyle(element, '').getPropertyValue('scroll-behavior')", "' instant'");

	33

	34 debug("");

	35 debug("Test getting and setting scroll-behavior through JS");

	36 element = document.createElement("div");

	37 document.body.appendChild(element);

	38 element.style.scrollBehavior = "smooth";

	39 shouldBe("getComputedStyle(element, '').getPropertyValue('scroll-behavior')", "' smooth'");

	40

	41 element.style.scrollBehavior = "instant";

	42 shouldBe("getComputedStyle(element, '').getPropertyValue('scroll-behavior')", "' instant'");

	43

	44 debug("");

	45 debug("Test the value 'initial'");

	46 element.style.scrollBehavior = "smooth";

	47 shouldBe("getComputedStyle(element, '').getPropertyValue('scroll-behavior')", "' smooth'");

	48 element.style.scrollBehavior = "initial";

	49 shouldBe("getComputedStyle(element, '').getPropertyValue('scroll-behavior')", "' instant'");

	50

	51 debug("");

	52 debug("Test the value 'inherit'");

	53 var parentElement = document.createElement("div");

	54 document.body.appendChild(parentElement);

	55 parentElement.style.scrollBehavior = "smooth";

	56 shouldBe("getComputedStyle(parentElement, '').getPropertyValue('scroll-behavior' )", "'smooth'");

	57 element = document.createElement("div");

	58 parentElement.appendChild(element);

	59 element.style.scrollBehavior = "inherit";

	60 shouldBe("getComputedStyle(element, '').getPropertyValue('scroll-behavior')", "' smooth'");

	61 </script>

	62 </body>
	Julien - ping for review 2014/01/22 16:24:35 I would throw an inheritance test for good measure I would throw an inheritance test for good measure, this would just double check that we don't inherit the property by mistake. ajuma 2014/01/22 19:50:20 Done. Show quoted text On 2014/01/22 16:24:35, Julien Chaffraix - PST wrote: > I would throw an inheritance test for good measure, this would just double check > that we don't inherit the property by mistake. Done.
	63 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/scroll-behavior/parse-scroll-behavior-expected.txt » ('j') | Source/build/scripts/name_utilities.py » ('J')