Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1402463005: Reuse category flush when outputing live regions. (Closed)

Created:
5 years, 2 months ago by David Tseng
Modified:
5 years, 2 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reuse category flush when outputing live regions. Fixes queueing up live region output when focus events occur. BUG=539019 Committed: https://crrev.com/be4174ec33927ec2d8554e1051c54cfb0e3bde61 Cr-Commit-Position: refs/heads/master@{#353908}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
David Tseng
5 years, 2 months ago (2015-10-13 19:25:47 UTC) #2
dmazzoni
lgtm https://codereview.chromium.org/1402463005/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js File chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js (right): https://codereview.chromium.org/1402463005/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js#newcode690 chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js:690: var queueMode = cvox.QueueMode.CATEGORY_FLUSH; Should this always be ...
5 years, 2 months ago (2015-10-13 20:20:40 UTC) #3
David Tseng
https://codereview.chromium.org/1402463005/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js File chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js (right): https://codereview.chromium.org/1402463005/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js#newcode690 chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js:690: var queueMode = cvox.QueueMode.CATEGORY_FLUSH; On 2015/10/13 20:20:40, dmazzoni wrote: ...
5 years, 2 months ago (2015-10-13 21:27:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402463005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402463005/20001
5 years, 2 months ago (2015-10-13 23:10:20 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-13 23:43:03 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 23:44:14 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/be4174ec33927ec2d8554e1051c54cfb0e3bde61
Cr-Commit-Position: refs/heads/master@{#353908}

Powered by Google App Engine
This is Rietveld 408576698