chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc - Issue 1402463004: [Smart Lock, UI] Change cancel button to Never, save prompt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc

Issue 1402463004: [Smart Lock, UI] Change cancel button to Never, save prompt. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc

diff --git a/chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc b/chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc

index e316ab7abbec307629c5e60d63d66d439f8732f1..e1ce37b36727b2791a8dc610cf039bc9136980a5 100644

--- a/chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc

+++ b/chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc

@@ -129,7 +129,7 @@ TEST_F(SavePasswordInfoBarDelegateTest, CancelTestCredentialSourceAPI) {

scoped_ptr<MockPasswordFormManager> password_form_manager(

CreateMockFormManager());

EXPECT_CALL(*password_form_manager.get(), PermanentlyBlacklist())

- .Times(testing::Exactly(0));

+ .Times(testing::Exactly(1));

vabr (Chromium) 2015/10/13 14:29:01 nit: Times(1) is implicit, so you can drop the ent

melandory 2015/10/14 11:46:11 Done.

scoped_ptr<ConfirmInfoBarDelegate> infobar(CreateDelegate(

password_form_manager.Pass(),

password_manager::CredentialSourceType::CREDENTIAL_SOURCE_API, false));

« no previous file with comments | « chrome/browser/password_manager/save_password_infobar_delegate.cc ('k') | no next file » | no next file with comments »