Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1402463004: [Smart Lock, UI] Change cancel button to Never, save prompt. (Closed)

Created:
5 years, 2 months ago by melandory
Modified:
5 years, 2 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock, UI] Change cancel button to Never, save prompt. Currently if save prompt was triggered via Credential Management API, the cancel button says "No Thanks" and do not blacklist the site. After this patch the button will say "Never" and id user presses the button, it will blacklist the site. BUG=528980 Committed: https://crrev.com/8fbacd4a393a056fe76e4cb1accf13ecfc03858d Cr-Commit-Position: refs/heads/master@{#354001}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -19 lines) Patch
M build/ios/grit_whitelist.txt View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/save_password_infobar_delegate.cc View 2 chunks +3 lines, -11 lines 0 comments Download
M chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
melandory
Hi Vaclav, please, review this CL.
5 years, 2 months ago (2015-10-13 14:21:56 UTC) #2
vabr (Chromium)
Thanks Tanja, LGTM! Vaclav https://codereview.chromium.org/1402463004/diff/1/chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc File chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc (right): https://codereview.chromium.org/1402463004/diff/1/chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc#newcode132 chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc:132: .Times(testing::Exactly(1)); nit: Times(1) is implicit, ...
5 years, 2 months ago (2015-10-13 14:29:01 UTC) #3
melandory
https://codereview.chromium.org/1402463004/diff/1/chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc File chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc (right): https://codereview.chromium.org/1402463004/diff/1/chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc#newcode132 chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc:132: .Times(testing::Exactly(1)); On 2015/10/13 14:29:01, vabr (Chromium) wrote: > nit: ...
5 years, 2 months ago (2015-10-14 11:46:11 UTC) #6
melandory
5 years, 2 months ago (2015-10-14 11:46:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402463004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402463004/20001
5 years, 2 months ago (2015-10-14 11:46:58 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-14 12:06:31 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 12:07:07 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8fbacd4a393a056fe76e4cb1accf13ecfc03858d
Cr-Commit-Position: refs/heads/master@{#354001}

Powered by Google App Engine
This is Rietveld 408576698